From: Thomas Monjalon <thomas@monjalon.net>
To: Weijun Pan <wpan3636@gmail.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Weijun Pan <wpan36@wisc.edu>
Cc: dev@dpdk.org, Sachin Saxena <sachin.saxena@nxp.com>,
Jun Yang <jun.yang@nxp.com>,
stable@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] bus/fslmc: fix shadowed variables in queue storage macros
Date: Wed, 10 Jun 2026 16:15:51 +0200 [thread overview]
Message-ID: <2S2V_VmSTBa7oGRJ0YAQqg@monjalon.net> (raw)
In-Reply-To: <20260407070940.225de771@phoenix.local>
07/04/2026 16:09, Stephen Hemminger:
> Why are these not inline functions.
> Macros with lower case names are likely place fore confusion like this?
Hemant, Sachin, Weijun, please could you consider this comment?
next prev parent reply other threads:[~2026-06-10 14:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-04 17:19 [PATCH] bus/fslmc: fix shadowed variables in queue storage macros Weijun Pan
2026-04-06 5:05 ` Hemant Agrawal
2026-04-07 14:09 ` Stephen Hemminger
2026-06-10 14:15 ` Thomas Monjalon [this message]
2026-06-11 14:11 ` David Marchand
2026-06-27 16:24 ` Weijun Pan
-- strict thread matches above, loose matches on Subject: below --
2026-04-07 14:19 Weijun Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2S2V_VmSTBa7oGRJ0YAQqg@monjalon.net \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jun.yang@nxp.com \
--cc=sachin.saxena@nxp.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=wpan3636@gmail.com \
--cc=wpan36@wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox