From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3] net/mlx5: support extended statistics
Date: Mon, 16 Jan 2017 16:18:41 +0000
Message-ID: <2a106ecd-6a38-59fa-3f7c-7cd9c357ff3e@intel.com>
References: <1484573439-10752-1-git-send-email-shahafs@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, Elad Persiko <eladpe@mellanox.com>
To: Shahaf Shuler <shahafs@mellanox.com>, adrien.mazarguil@6wind.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 1B8EB1094
 for <dev@dpdk.org>; Mon, 16 Jan 2017 17:18:43 +0100 (CET)
In-Reply-To: <1484573439-10752-1-git-send-email-shahafs@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Shahaf,

On 1/16/2017 1:30 PM, Shahaf Shuler wrote:
> Implement extended statistics callbacks.
> 
> Suggested-by: Hanoch Haim <hhaim@cisco.com>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> Signed-off-by: Elad Persiko <eladpe@mellanox.com>

I am getting following build error [1] with clang when MLX5_DEBUG=y,
this seems because of pedandic.

Variable length array supported by language with c99 but mlx is forcing
to compile itself with gnu99 (-std=gnu99), not sure why, which supports
variable length array as an extension.


[1]
 .../drivers/net/mlx5/mlx5_stats.c:266:20: error: variable length array
folded to constant array as an extension [-Werror,-Wgnu-folding-constant]
        uint64_t counters[xstats_n];
                          ^~~~~~~~
 .../drivers/net/mlx5/mlx5_stats.c:289:20: error: variable length array
folded to constant array as an extension [-Werror,-Wgnu-folding-constant]
        uint64_t counters[xstats_n];
                          ^~~~~~~~