From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anand Rawat <anand.rawat@intel.com>
Subject: Re: [PATCH v2 6/6] doc: add documention for windows
Date: Thu, 7 Mar 2019 10:46:30 -0800
Message-ID: <2ae345c8-d9e3-89e6-46db-8ef30d62d61b@intel.com>
References: <20190306041634.12976-1-anand.rawat@intel.com>
 <20190306041634.12976-7-anand.rawat@intel.com>
 <6DC05C7C5F25994B81B3F2F214251F66020A3FA5@IRSMSX104.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "Kadam, Pallavi" <pallavi.kadam@intel.com>,
 "Menon, Ranjit" <ranjit.menon@intel.com>,
 "Shaw, Jeffrey B" <jeffrey.b.shaw@intel.com>,
 "thomas@monjalon.net" <thomas@monjalon.net>
To: "Kovacevic, Marko" <marko.kovacevic@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by dpdk.org (Postfix) with ESMTP id 90A8C5589
 for <dev@dpdk.org>; Thu,  7 Mar 2019 19:46:31 +0100 (CET)
In-Reply-To: <6DC05C7C5F25994B81B3F2F214251F66020A3FA5@IRSMSX104.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/7/2019 9:03 AM, Kovacevic, Marko wrote:
>> Added documentation to build helloworld example on windows using meson
>> and clang. Updated the maintainers list to include windows maintainers.
>>
>> Signed-off-by: Anand Rawat <anand.rawat@intel.com>
>> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
>> Reviewed-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
>> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
>> ---
>>   MAINTAINERS                           |  7 +++
>>   doc/guides/index.rst                  |  3 +-
>>   doc/guides/windows_gsg/build_dpdk.rst | 67
>> +++++++++++++++++++++++++++
>>   doc/guides/windows_gsg/index.rst      | 14 ++++++
>>   doc/guides/windows_gsg/intro.rst      | 20 ++++++++
>>   5 files changed, 110 insertions(+), 1 deletion(-)  create mode 100644
>> doc/guides/windows_gsg/build_dpdk.rst
>>   create mode 100644 doc/guides/windows_gsg/index.rst  create mode
>> 100644 doc/guides/windows_gsg/intro.rst
>>
> 
> Make doc html 50848
> sphinx processing guides-html...
> dpdk/doc/guides/windows_gsg/build_dpdk.rst:28: WARNING: Unknown target name: "meson's website<http://mesonbuild.com/getting-meson.html>".
> dpdk/doc/guides/windows_gsg/build_dpdk.rst:36: WARNING: Unknown target name: "ninja's website<https://ninja-build.org/>".
> 
> 
> <...>
> 
>> +
>> +Install the Build System
>> +------------------------
>> +
>> +Download and install the build system from `Meson's
>> website<http://mesonbuild.com/Getting-meson.html>`_.
>> +A good option to choose is the MSI installer for both meson and ninja
>> together::
>> +
> 
> Space is needed after website for the link to be properly made.
> 
> -Download and install the build system from `Meson's website<http://mesonbuild.com/Getting-meson.html>`_.
> +Download and install the build system from `Meson's website <http://mesonbuild.com/Getting-meson.html>`_.
> 
>> +
>> +http://mesonbuild.com/Getting-meson.html#installing-meson-and-ninja-
>> wit
>> +h-the-msi-installer%22
>> +
>> +Install the Backend
>> +-------------------
>> +
>> +If using Ninja, download and install the backend from `Ninja's
>> +website<https://ninja-build.org/>`_ or install along with the meson build
>> system.
>> +
> 
> Also here:
> -If using Ninja, download and install the backend from `Ninja's website<https://ninja-build.org/>`_ or
> +If using Ninja, download and install the backend from `Ninja's website <https://ninja-build.org/>`_ or
> 
> <...>
> 

Thank You, will update in v3

-- 
Anand Rawat