From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] net/tap: fix invalid queue file descriptor
Date: Mon, 30 Oct 2017 15:55:48 -0700
Message-ID: <2aeb75a6-7fcd-1d93-e424-7994e044a06b@intel.com>
References: <1509011493-26531-1-git-send-email-liupengzhen3@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Keith Wiles <keith.wiles@intel.com>
To: Pengzhen Liu <liupengzhen3@huawei.com>, thomas@monjalon.net
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 39EB51B1B8
 for <dev@dpdk.org>; Mon, 30 Oct 2017 23:55:49 +0100 (CET)
In-Reply-To: <1509011493-26531-1-git-send-email-liupengzhen3@huawei.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/26/2017 2:51 AM, Pengzhen Liu wrote:
> From: Keith Wiles <keith.wiles@intel.com>
> 
> Rx and Tx queues share the common tap file descriptor, but save this
> value separately.
> 
> Setting up Rx/Tx queue sets up both queues, release_queue close the
> tap file but update file descriptor only for that queue.
> 
> This makes other queue's file descriptor invalid.
> 
> As a workaround, prevent release_queue callback to be called by default.
> 
> This is done by separating Rx/Tx setup functions, so that each only
> setup its own queue, this prevents rte_eth_rx/tx_queue_setup() calling
> release_queue before setup_queue.
> 
> Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD")
> 
> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Hi Pengzhen,

This is a commit from repo :) [1] from beginning of the year.

I assume this has been sent instead of another patch by mistake, please double
check if intended patch sent to mail list.

[1]
http://dpdk.org/commit/0002ca58