From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hemant Agrawal Subject: Re: [PATCH v2] doc: update ethdev APIs to return named opaque type Date: Tue, 13 Feb 2018 09:22:02 +0530 Message-ID: <2b154134-d1e5-f7db-e38f-43900b48f91e@nxp.com> References: <20180209101119.69860-1-ferruh.yigit@intel.com> <20180209101818.70041-1-ferruh.yigit@intel.com> <2601191342CEEE43887BDE71AB977258905710B0@irsmsx105.ger.corp.intel.com> <20180210120229.GB7298@jerin> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "Yigit, Ferruh" , Neil Horman , "Mcnamara, John" , "Kovacevic, Marko" , "dev@dpdk.org" , Stephen Hemminger , "Richardson, Bruce" , Thomas Monjalon To: Jerin Jacob , "Ananyev, Konstantin" Return-path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10050.outbound.protection.outlook.com [40.107.1.50]) by dpdk.org (Postfix) with ESMTP id B2FB61B2D5 for ; Tue, 13 Feb 2018 04:52:20 +0100 (CET) In-Reply-To: <20180210120229.GB7298@jerin> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/10/2018 5:32 PM, Jerin Jacob wrote: >>> -----Original Message----- >>> From: Yigit, Ferruh >>> Sent: Friday, February 9, 2018 10:18 AM >>> To: Neil Horman ; Mcnamara, John ; Kovacevic, Marko >>> >>> Cc: dev@dpdk.org; Yigit, Ferruh ; Ananyev, Konstantin ; Stephen Hemminger >>> ; Richardson, Bruce ; Thomas Monjalon >>> Subject: [PATCH v2] doc: update ethdev APIs to return named opaque type >>> >>> Ethdev APIs to add callback return the callback object as "void *", >>> update return type to actual object type >>> "struct rte_eth_rxtx_callback *" >>> >>> Signed-off-by: Ferruh Yigit >>> --- >>> Cc: Konstantin Ananyev >>> Cc: Stephen Hemminger >>> Cc: Bruce Richardson >>> Cc: Thomas Monjalon >>> --- >>> doc/guides/rel_notes/deprecation.rst | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst >>> index bbd9456a7..5cb5a00d2 100644 >>> --- a/doc/guides/rel_notes/deprecation.rst >>> +++ b/doc/guides/rel_notes/deprecation.rst >>> @@ -49,6 +49,13 @@ Deprecation Notices >>> rte_eth_dev_get_sec_ctx() is using uint8_t for port_id, which should be >>> uint16_t. >>> >>> +* ethdev: functions add rx/tx callback will return named opaque type >>> + rte_eth_add_rx_callback(), rte_eth_add_first_rx_callback() and >>> + rte_eth_add_tx_callback() functions currently return callback object as >>> + "void \*" but APIs to delete callbacks get "struct rte_eth_rxtx_callback \*" >>> + as parameter. For consistency functions adding callback will return >>> + "struct rte_eth_rxtx_callback \*" instead of "void * ". >>> + >>> * i40e: The default flexible payload configuration which extracts the first 16 >>> bytes of the payload for RSS will be deprecated starting from 18.02. If >>> required the previous behavior can be configured using existing flow >>> -- >> >> Acked-by: Konstantin Ananyev > > Acked-by: Jerin Jacob > >> Acked-by: Hemant Agrawal