From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 1/4] net/nfp: add NFP CPP support Date: Fri, 30 Mar 2018 11:37:15 +0100 Message-ID: <2b74b6bf-5b41-b64c-5568-6fcbead8c629@intel.com> References: <1521826504-20195-1-git-send-email-alejandro.lucero@netronome.com> <1521826504-20195-2-git-send-email-alejandro.lucero@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Hemant Agrawal To: Alejandro Lucero , dev@dpdk.org Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id A368E5F27 for ; Fri, 30 Mar 2018 12:37:17 +0200 (CEST) In-Reply-To: <1521826504-20195-2-git-send-email-alejandro.lucero@netronome.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/23/2018 5:35 PM, Alejandro Lucero wrote: > CPP refers to the internal NFP Command Push Pull bus. This patch allows > to create CPP commands from user space allowing to access any single > part of the chip. > > This CPP interface is the base for having other functionalities like > mutexes when accessing specific chip components, chip resources management, > firmware upload or using the NSP, an embedded arm processor which can > perform tasks on demand. > > NSP was the previous only way for doing things in the chip by the PMD, > where a NSPU interface was used for commands like firmware upload or > port link configuration. CPP interface supersedes NSPU, but it is still > possible to use NSP through CPP. > > CPP interface adds a great flexibility for doing things like extended > stats, firmware debugging or selecting properly the firmware file to > upload. It can be good to announce this new feature in release notes, what do you think? Also get some build errors [1], one is about zlib.h, normally we disable PMDs by default with external dependencies, is nfp depends to libz with this patch? [1] ...dpdk/drivers/net/nfp/nfpcore/nfp_mutex.c:295:28: error: format specifies type 'short' but the argument has type 'unsigned int' [-Werror,-Wformat] printf("\tusage:%hd\n", mutex->usage); ~~~ ^~~~~~~~~~~~ %u ...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c:819:1: error: unused function '__nfp_bytemask_of' [-Werror,-Wunused-function] __nfp_bytemask_of(int width, uint64_t addr) ^ ...dpdk/drivers/net/nfp/nfp_net.c:2971:35: error: format specifies type 'unsigned char' but the argument has type 'uint32_t' (aka 'unsigned int') [-Werror,-Wformat] cpp->serial[4], cpp->serial[5], cpp->interface >> 8, ^~~~~~~~~~~~~~~~~~~ ...dpdk/drivers/net/nfp/nfp_net.c:2972:3: error: format specifies type 'unsigned char' but the argument has type 'unsigned int' [-Werror,-Wformat] cpp->interface & 0xff); ^~~~~~~~~~~~~~~~~~~~~ ...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c: In function ‘nfp_cpp_area_readl’: ...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c:459:9: error: ‘tmp’ may be used uninitialized in this function [-Werror=maybe-uninitialized] *value = rte_le_to_cpu_32(tmp); ...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c: In function ‘nfp_cpp_area_readq’: ...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c:483:9: error: ‘tmp’ may be used uninitialized in this function [-Werror=maybe-uninitialized] *value = rte_le_to_cpu_64(tmp); ...dpdk/drivers/net/nfp/nfpcore/nfp_resource.c:34:10: fatal error: zlib.h: No such file or directory #include ^~~~~~~~ > > Signed-off-by: Alejandro Lucero <...> > diff --git a/drivers/net/nfp/nfpcore/nfp-common/nfp_cppat.h b/drivers/net/nfp/nfpcore/nfp-common/nfp_cppat.h > new file mode 100644 > index 0000000..fbeec57 > --- /dev/null > +++ b/drivers/net/nfp/nfpcore/nfp-common/nfp_cppat.h > @@ -0,0 +1,748 @@ > +/* > + * Copyright (c) 2018 Netronome Systems, Inc. > + * All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions are met: > + * > + * 1. Redistributions of source code must retain the above copyright notice, > + * this list of conditions and the following disclaimer. > + * > + * 2. Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in the > + * documentation and/or other materials provided with the distribution > + * > + * 3. Neither the name of the copyright holder nor the names of its > + * contributors may be used to endorse or promote products derived from this > + * software without specific prior written permission. > + * > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" > + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE > + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE > + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE > + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR > + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF > + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS > + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN > + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) > + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE > + * POSSIBILITY OF SUCH DAMAGE. > + */ Can you please add new files with SPDX tags?