From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22FE8C4363D for ; Thu, 24 Sep 2020 15:27:04 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 8F0A421D91 for ; Thu, 24 Sep 2020 15:27:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F0A421D91 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8387F1DDE5; Thu, 24 Sep 2020 17:27:01 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 3A4D41DDC9 for ; Thu, 24 Sep 2020 17:27:00 +0200 (CEST) IronPort-SDR: da3YoNSf6fu9SMxVuVRcqMZSnf2Z8cQoVrN57XRctThHZo8GNzuuxunSMEB2cezIGM7qXHqNOL 4EBbo4078vQg== X-IronPort-AV: E=McAfee;i="6000,8403,9753"; a="148991648" X-IronPort-AV: E=Sophos;i="5.77,298,1596524400"; d="scan'208";a="148991648" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2020 08:26:59 -0700 IronPort-SDR: wz7S9bwdojYrQ09IN5A7+2BkTarbASgu4BuMMyutJpv2DZrFqTZu0621RmT1jODB5ejnpr8oxR NPf9QUmig5UA== X-IronPort-AV: E=Sophos;i="5.77,298,1596524400"; d="scan'208";a="512204147" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.251.85.112]) ([10.251.85.112]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2020 08:26:58 -0700 To: Phil Yang , David Liu Cc: "dev@dpdk.org" , "lylavoie@iol.unh.edu" , "thomas@monjalon.net" , nd References: <20200915154208.50383-1-dliu@iol.unh.edu> <20200915172740.55178-1-dliu@iol.unh.edu> From: Ferruh Yigit Message-ID: <2c4935de-5b4d-3cf9-2e4d-9757ae502d29@intel.com> Date: Thu, 24 Sep 2020 16:26:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] [PATCH V2] testpmd: add eeprom/module eeprom display X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/24/2020 11:57 AM, Phil Yang wrote: > > dev On Behalf Of Phil Yang : writes: > > >>> Subject: [dpdk-dev] [PATCH] [PATCH V2] testpmd: add eeprom/module >>> eeprom display >>> >>> Add module EEPROM/EEPROM dump command >>> "show port (module_eeprom|eeprom)" >>> Commands will dump the content of the EEPROM/module >>> EEPROM for the selected port. >> >> >> Verified with some popular NICs, it can dump the same info as the Linux >> ethtool does. >> This is supported in examples/ethtool as well. >> >> Minor nitpick comments inlined. >> >> Thanks, >> Phil >> >>> >>> Signed-off-by: David Liu <...> > > Reviewed-by: Phil Yang > Reviewed-by: Ferruh Yigit (empty line above include fixed while merging.) Applied to dpdk-next-net/main, thanks.