From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] net/nfp: fix Vlan offload flags check Date: Fri, 13 Jan 2017 12:03:01 +0000 Message-ID: <2c9b018f-bad8-449a-acf7-e2da82bdc464@intel.com> References: <1484226296-540-1-git-send-email-olivier.matz@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: Olivier Matz , dev@dpdk.org, alejandro.lucero@netronome.com Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 163542B97 for ; Fri, 13 Jan 2017 15:32:35 +0100 (CET) In-Reply-To: <1484226296-540-1-git-send-email-olivier.matz@6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/12/2017 1:04 PM, Olivier Matz wrote: > Fix typo when checking that no Vlan offload flags are passed at port > initialization. > > By the way, also fix a typo in the log. > > Fixes: d4a27a3b092a ("nfp: add basic features") > > Signed-off-by: Olivier Matz > --- > drivers/net/nfp/nfp_net.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c > index 65ba09f..ed3c9b8 100644 > --- a/drivers/net/nfp/nfp_net.c > +++ b/drivers/net/nfp/nfp_net.c > @@ -2174,8 +2174,8 @@ nfp_net_vlan_offload_set(struct rte_eth_dev *dev, int mask) > new_ctrl = 0; > > if ((mask & ETH_VLAN_FILTER_OFFLOAD) || > - (mask & ETH_VLAN_FILTER_OFFLOAD)) > - RTE_LOG(INFO, PMD, "Not support for ETH_VLAN_FILTER_OFFLOAD or" > + (mask & ETH_VLAN_FILTER_EXTEND)) I can't find "ETH_VLAN_FILTER_EXTEND", do you mean "ETH_VLAN_EXTEND_OFFLOAD" ? > + RTE_LOG(INFO, PMD, "No support for ETH_VLAN_FILTER_OFFLOAD or" > " ETH_VLAN_FILTER_EXTEND"); > > /* Enable vlan strip if it is not configured yet */ >