From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: Remaining old offloading API usage in PMDs
Date: Mon, 21 May 2018 15:33:56 +0100
Message-ID: <2cb2301a-88f5-cfdd-1c38-f2d41ed56c7d@intel.com>
References: <9a1b4500-d354-bdef-45d3-7d6eeacfb54b@intel.com>
 <8fe6b45b-7fb3-0551-39ec-02ba94ef16cb@intel.com>
 <CAD+H991tQCqYYx4WGye3Yd_OD3szWy_VRtwcK-=Bs8DosYtZjQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Thomas Monjalon <thomas@monjalon.net>,
 Andrew Rybchenko <arybchenko@solarflare.com>,
 Tetsuya Mukawa <mtetsuyah@gmail.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 Shreyansh Jain <shreyansh.jain@nxp.com>, dpdk-dev <dev@dpdk.org>,
 Beilei Xing <beilei.xing@intel.com>, Qi Zhang <qi.z.zhang@intel.com>
To: Alejandro Lucero <alejandro.lucero@netronome.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id D08261B1CC
 for <dev@dpdk.org>; Mon, 21 May 2018 16:34:00 +0200 (CEST)
In-Reply-To: <CAD+H991tQCqYYx4WGye3Yd_OD3szWy_VRtwcK-=Bs8DosYtZjQ@mail.gmail.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/21/2018 3:16 PM, Alejandro Lucero wrote:
> I completely missed this last bit in the NFP driver.
> 
> I will send a patch today.
> 
> By the way, will it go into 18.05? I ask because I have another patch fixing a
> problem which would be good to have in 18.05 as well.

Release is still open for fixes, specially for PMDs since their scope is
limited. After rc5 plan is to get only critical fixes.

> 
> On Mon, May 21, 2018 at 1:38 PM, Ferruh Yigit <ferruh.yigit@intel.com
> <mailto:ferruh.yigit@intel.com>> wrote:
> 
>     On 5/11/2018 11:45 AM, Ferruh Yigit wrote:
>     > Some PMDs are still using old offloading API related variables, thanks to
>     Andrew
>     > for reporting it.
>     >
>     > Maintainers of related PMDs are cc'ed.
>     > Please check following list and provide a fix ASAP for it, thanks.
>     >
>     >
>     > # git grep header_split drivers/
>     > drivers/net/i40e/i40e_rxtx_vec_common.h:        if (rxmode->header_split == 1)
>     >
>     > # git grep hw_vlan_filter drivers/
>     > drivers/net/i40e/i40e_vf_representor.c:         if
>     > (ethdev->data->dev_conf.rxmode.hw_vlan_filter)
>     > drivers/net/vhost/rte_eth_vhost.c:      if (rxmode->hw_vlan_filter)
>     >
>     > # git grep hw_vlan_strip drivers/
>     > drivers/net/dpaa2/dpaa2_rxtx.c:         if
>     > (dev->data->dev_conf.rxmode.hw_vlan_strip)
>     > drivers/net/i40e/i40e_vf_representor.c:         if
>     > (ethdev->data->dev_conf.rxmode.hw_vlan_strip)T
>     > drivers/net/vhost/rte_eth_vhost.c:      internal->vlan_strip =
>     > rxmode->hw_vlan_strip;
>     >
>     > # git grep hw_vlan_extend drivers/
>     > drivers/net/i40e/i40e_rxtx_vec_common.h:        if (rxmode->hw_vlan_extend
>     == 1)
>     >
>     > # git grep hw_strip_crc drivers/
>     > drivers/net/nfp/nfp_net.c:      rxq->crc_len = (uint8_t)
>     > ((dev->data->dev_conf.rxmode.hw_strip_crc) ? 0
>     > drivers/net/sfc/sfc_rx.c:               rxmode->hw_strip_crc = 1;
>     >
> 
>     Reminder of this one.
> 
>