From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 27/37] net/ice/base: resolve static analysis reported issues Date: Fri, 1 Mar 2019 10:36:40 +0000 Message-ID: <2cbc92e7-f1d2-0d5e-9c4e-4074bd08975d@intel.com> References: <20190228055650.25237-1-qi.z.zhang@intel.com> <20190228055650.25237-28-qi.z.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: paul.m.stillwell.jr@intel.com, dev@dpdk.org, Bruce Allan To: Qi Zhang , wenzhuo.lu@intel.com, qiming.yang@intel.com Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 314252B9E for ; Fri, 1 Mar 2019 11:36:42 +0100 (CET) In-Reply-To: <20190228055650.25237-28-qi.z.zhang@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/28/2019 5:56 AM, Qi Zhang wrote: > Resolve static analysis reported issue in > ice_get_itr_intrl_gran and ice_ptg_find_ptype. Same comment with previous patch, related to the commit log. Commit log says "static analysis reported issues" are solved, what are they really? If we know them we can know your intention and say something about the code below, otherwise is there a way to figure out if something wrong below? And "impact" part, "what is the impact of the change?" Will those issues create definite memory corruption? Or protection for possible issue. Knowing this helps maintainers and LTS maintainers to priorities the patch accordingly. Also please use "fix" instead of "resolve", fix is kind of keyword we tend to use, and provide a fixes line for whatever fixed. > > Signed-off-by: Bruce Allan > Signed-off-by: Paul M Stillwell Jr > Signed-off-by: Qi Zhang