From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [PATCH] ethdev: fix missing names in Tx offload name
 array
Date: Mon, 10 Sep 2018 12:09:07 +0300
Message-ID: <2d0b247c-e15d-f88b-a613-6017db7e4017@solarflare.com>
References: <1536235311-43741-1-git-send-email-dekelp@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <xuemingl@mellanox.com>, <orika@mellanox.com>
To: Dekel Peled <dekelp@mellanox.com>, <thomas@monjalon.net>,
 <ferruh.yigit@intel.com>, <arybchenko@solarflare.com>, <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id B37421559
 for <dev@dpdk.org>; Mon, 10 Sep 2018 11:09:41 +0200 (CEST)
In-Reply-To: <1536235311-43741-1-git-send-email-dekelp@mellanox.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 09/06/2018 03:01 PM, Dekel Peled wrote:
> Patch 5355f443 added two definitions of DEV_TX_OFFLOAD_xxx.
> If new Tx offload capabilities are defined, they also must be mentioned
> in rte_tx_offload_names in rte_ethdev.c file.
>
> This patch adds the required lines in aray rte_tx_offload_names.
>
> Fixes: 5355f4439e2e ("ethdev: introduce generic IP/UDP tunnel checksum and TSO")
>
> Cc: xuemingl@mellanox.com
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
>   lib/librte_ethdev/rte_ethdev.c | 2 ++
>   lib/librte_ethdev/rte_ethdev.h | 4 ++--
>   2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
> index 3f8de93..5004b9f 100644
> --- a/lib/librte_ethdev/rte_ethdev.c
> +++ b/lib/librte_ethdev/rte_ethdev.c
> @@ -156,6 +156,8 @@ struct rte_eth_xstats_name_off {
>   	RTE_TX_OFFLOAD_BIT2STR(MULTI_SEGS),
>   	RTE_TX_OFFLOAD_BIT2STR(MBUF_FAST_FREE),
>   	RTE_TX_OFFLOAD_BIT2STR(SECURITY),
> +	RTE_TX_OFFLOAD_BIT2STR(UDP_TNL_TSO),
> +	RTE_TX_OFFLOAD_BIT2STR(IP_TNL_TSO),
>   };
>   
>   #undef RTE_TX_OFFLOAD_BIT2STR
> diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
> index fa2812b..5456ce2 100644
> --- a/lib/librte_ethdev/rte_ethdev.h
> +++ b/lib/librte_ethdev/rte_ethdev.h
> @@ -941,18 +941,18 @@ struct rte_eth_conf {
>    *   the same mempool and has refcnt = 1.
>    */
>   #define DEV_TX_OFFLOAD_SECURITY         0x00020000
> +#define DEV_TX_OFFLOAD_UDP_TNL_TSO      0x00040000
>   /**
>    * Device supports generic UDP tunneled packet TSO.
>    * Application must set PKT_TX_TUNNEL_UDP and other mbuf fields required
>    * for tunnel TSO.
>    */
> -#define DEV_TX_OFFLOAD_UDP_TNL_TSO      0x00040000
> +#define DEV_TX_OFFLOAD_IP_TNL_TSO       0x00080000
>   /**
>    * Device supports generic IP tunneled packet TSO.
>    * Application must set PKT_TX_TUNNEL_IP and other mbuf fields required
>    * for tunnel TSO.
>    */
> -#define DEV_TX_OFFLOAD_IP_TNL_TSO       0x00080000

I don't understand why it is changed. Comments should be before define.

>   
>   #define RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP 0x00000001
>   /**< Device supports Rx queue setup after device started*/