dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Bing Zhao <bingz@nvidia.com>,
	viacheslavo@nvidia.com, dev@dpdk.org, rasland@nvidia.com
Cc: orika@nvidia.com, dsosnowski@nvidia.com, suanmingm@nvidia.com,
	matan@nvidia.com, thomas@monjalon.net,
	Roi Dayan <roid@nvidia.com>,
	xuemingl@nvidia.com, Shani Peretz <shperetz@nvidia.com>
Subject: Re: [PATCH 1/4] net/mlx5: release representor interrupt handler
Date: Thu, 20 Nov 2025 17:08:17 +0000	[thread overview]
Message-ID: <2da88441-307a-4287-8387-d1906edf3755@redhat.com> (raw)
In-Reply-To: <20251112074015.8901-1-bingz@nvidia.com>

On 12/11/2025 07:40, Bing Zhao wrote:
> From: Roi Dayan <roid@nvidia.com>
> 
> Looks like commit the cited commit removed the representor
> interrupt handler cleanup by mistake. Fix it.
> 
> Fixes: 5cf0707fc7e9 ("net/mlx5: remove Rx queue data list from device")
> Cc: xuemingl@nvidia.com
> 

Hi,

Some of this series (see below) is fixing issues in older releases, but
does not include stable tag to indicate the fixes should be backported.

Just checking if this is deliberate, or an oversight and they should be
backported ?

thanks,
Kevin.

25.11 dbaed15366 - F net/mlx5: release representor interrupt handler
(Fixes issue in 21.11)

25.11 aef94343d3 - F common/mlx5: release unused mempool entries (Fixes
issue in  21.11 (partially fixed in 8947eebc999e @ 21.11))

25.11 8d1fe10768 - F net/mlx5/hws: fix buddy memory allocation (Fixes
issue in 22.11)


> Signed-off-by: Roi Dayan <roid@nvidia.com>
> ---
>  drivers/net/mlx5/mlx5.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
> index 666216c21a..591420c77f 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -2389,6 +2389,11 @@ mlx5_dev_close(struct rte_eth_dev *dev)
>  	/* Free the eCPRI flex parser resource. */
>  	mlx5_flex_parser_ecpri_release(dev);
>  	mlx5_flex_item_port_cleanup(dev);
> +	if (priv->representor) {
> +		/* Each representor has a dedicated interrupts handler */
> +		rte_intr_instance_free(dev->intr_handle);
> +		dev->intr_handle = NULL;
> +	}
>  	mlx5_indirect_list_handles_release(dev);
>  #ifdef HAVE_MLX5_HWS_SUPPORT
>  	mlx5_nta_sample_context_free(dev);


  parent reply	other threads:[~2025-11-20 17:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-12  7:40 [PATCH 1/4] net/mlx5: release representor interrupt handler Bing Zhao
2025-11-12  8:35 ` Suanming Mou
2025-11-17 13:48 ` Raslan Darawsheh
2025-11-20 17:08 ` Kevin Traynor [this message]
2025-11-20 17:39   ` Thomas Monjalon
2025-11-20 17:59     ` Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2da88441-307a-4287-8387-d1906edf3755@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=bingz@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=dsosnowski@nvidia.com \
    --cc=matan@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=roid@nvidia.com \
    --cc=shperetz@nvidia.com \
    --cc=suanmingm@nvidia.com \
    --cc=thomas@monjalon.net \
    --cc=viacheslavo@nvidia.com \
    --cc=xuemingl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).