From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] mk: remove module compilation noise
Date: Fri, 23 Sep 2016 10:04:58 +0100
Message-ID: <2e084452-347c-4553-4343-024a10412639@intel.com>
References: <1473337981-27378-1-git-send-email-ferruh.yigit@intel.com>
 <6873211.QDWnoOkD9j@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 7601E5A0A
 for <dev@dpdk.org>; Fri, 23 Sep 2016 11:06:03 +0200 (CEST)
In-Reply-To: <6873211.QDWnoOkD9j@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/23/2016 12:35 AM, Thomas Monjalon wrote:
> 2016-09-08 13:33, Ferruh Yigit:
>> Following log generated by Linux kernel Makefiles:
>> (cat /dev/null;   echo
>> kernel/.../build/lib/librte_eal/linuxapp/igb_uio/igb_uio.ko;) >
>> .../build/lib/librte_eal/linuxapp/igb_uio/modules.order
>>
>> This happens because $(Q) used for both Linux and DPDK makefiles and
>> DPDK unsets this variable when V=0, which makes Linux verbose.
>>
>> More details:
>> rte.modules calls kernel makefile with V=0 argument
>> kernel makefile includes igb_uio/Makefile, which includes rte.vars.mk
>> rte.vars.mk unsets Q when V=0
> 
> Yes good analysis.
> Another consequence is that V=0 is equivalent to V=1 (verbose mode).

Yes.

> I think it is better to fix the latter issue. I'll send a patch.

OK.