public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: Luca Vizzarro <Luca.Vizzarro@arm.com>
To: Dean Marx <dmarx@iol.unh.edu>,
	probb@iol.unh.edu, yoan.picchi@foss.arm.com,
	Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com
Cc: dev@dpdk.org, Andrew Bailey <abailey@iol.unh.edu>
Subject: Re: [PATCH v2] dts: update overall result pass/skip logic
Date: Fri, 20 Mar 2026 10:41:07 +0000	[thread overview]
Message-ID: <2e433dc1-2dbc-422b-911f-bb633350fed7@arm.com> (raw)
In-Reply-To: <20260313182240.130379-1-dmarx@iol.unh.edu>

Hi Dean,

Thank you for your patch. I agree with Patrick on this one. The overall 
result is indeed obtained by doing max on the results, which would yield 
the maximum severity found. Technically speaking we could indeed say 
that SKIP is less severe or important than PASS.

If we have a test suite with only SKIP the max will be SKIP, if we have 
a test suite with SKIP and PASS, the max will be PASS.

The rest of the logic would remain unchanged, meaning that if we have 
SKIP, PASS, FAIL, then the max will still be FAIL.

Therefore, I agree that the solution to this is as simple as re-ordering 
the IntEnum, by swapping SKIP and PASS.

Best,
Luca

  parent reply	other threads:[~2026-03-20 10:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13 15:56 [PATCH v1] dts: update overall result pass/skip logic Dean Marx
2026-03-13 17:07 ` Andrew Bailey
2026-03-13 18:22 ` [PATCH v2] " Dean Marx
2026-03-16 16:17   ` Patrick Robb
2026-03-20  4:26   ` Patrick Robb
2026-03-20 10:41   ` Luca Vizzarro [this message]
2026-03-20 15:36     ` Dean Marx
2026-03-20 15:46   ` [PATCH v3] " Dean Marx
2026-03-20 18:21     ` [PATCH v4] " Dean Marx
2026-03-20 21:09       ` Patrick Robb
2026-03-23 14:01       ` Luca Vizzarro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e433dc1-2dbc-422b-911f-bb633350fed7@arm.com \
    --to=luca.vizzarro@arm.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=abailey@iol.unh.edu \
    --cc=dev@dpdk.org \
    --cc=dmarx@iol.unh.edu \
    --cc=paul.szczepanek@arm.com \
    --cc=probb@iol.unh.edu \
    --cc=yoan.picchi@foss.arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox