From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v7 9/9] eal: enable hotplugging of devices on
	bus
Date: Tue, 17 Jan 2017 19:10:11 +0530
Message-ID: <2e6605fe-b351-b406-1629-d8b2eb3d5fb4@nxp.com>
References: <1484581107-2025-1-git-send-email-shreyansh.jain@nxp.com>
 <1484647774-28984-1-git-send-email-shreyansh.jain@nxp.com>
 <1484647774-28984-10-git-send-email-shreyansh.jain@nxp.com>
 <efeef9a6-05b7-6637-aec0-fa3dcbd2d7bb@intel.com>
 <DB5PR0401MB20543DA5450E4EB550F06001907C0@DB5PR0401MB2054.eurprd04.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, "thomas.monjalon@6wind.com"
 <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, "david.marchand@6wind.com"
 <david.marchand@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-BL2-obe.outbound.protection.outlook.com
 (mail-bl2nam02on0059.outbound.protection.outlook.com [104.47.38.59])
 by dpdk.org (Postfix) with ESMTP id B29F02C4F
 for <dev@dpdk.org>; Tue, 17 Jan 2017 14:36:47 +0100 (CET)
In-Reply-To: <DB5PR0401MB20543DA5450E4EB550F06001907C0@DB5PR0401MB2054.eurprd04.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hello Ferruh,

On Tuesday 17 January 2017 04:34 PM, Shreyansh Jain wrote:
> Hi Ferruh,
>
>> -----Original Message-----
>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
>> Sent: Tuesday, January 17, 2017 4:18 PM
>> To: Shreyansh Jain <shreyansh.jain@nxp.com>; david.marchand@6wind.com
>> Cc: dev@dpdk.org; thomas.monjalon@6wind.com
>> Subject: Re: [dpdk-dev] [PATCH v7 9/9] eal: enable hotplugging of devices on
>> bus
>>
>> On 1/17/2017 10:09 AM, Shreyansh Jain wrote:
>>> Given a bus, attach and detach callbacks allow the implementation to
>>> handles calls from EAL for attaching or detaching a named device.
>>>
>>> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
>>
>> <...>
>>
>>> +/**
>>> + * Search and detach a PCI device from PCI Bus
>>> + * Implements rte_bus->detach
>>> + *
>>> + * @param device_name
>>> + *	Name of the device to search and detach
>>> + *
>>> + * @return
>>> + *	0 for successful detaching of device
>>> + *	>0 if device not found on bus
>>> + *	<0 in case of error in removal.
>>
>> These are the return values expected by rte_eal_dev_detach(), but
>> rte_eal_pci_detach() is not following these right now, which is causing
>> failure on detaching virtual devices.
>>
>> Fix is not complex, it may be an option to fix this as a separate patch
>> after this patchset applied.
>
> Ok. I will have a look and fix it.
> If possible I will push v8; keeping it pending is lower preference for me.

I have sent a v8 to fix this (issue was indeed there). I have not used
reviewed-by from you on v8 9/9.

>
>>
>>> + */
>>> +int
>>> +rte_eal_pci_detach(const char *device_name);
>>> +
>>> +/**
>>
>> <...>
>
>