From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radu Nicolau <radu.nicolau@intel.com>
Subject: Re: [PATCH] net/bonding: propagate promiscous mode in
 mode 4
Date: Wed, 1 Aug 2018 14:47:58 +0100
Message-ID: <2eac631f-1402-67b5-04de-1ce161cfcf92@intel.com>
References: <1533128278-4685-1-git-send-email-radu.nicolau@intel.com>
 <CAG2-GknPmLqRG_RV+=R3WMYL8hnTff5fo63rk2nPGd4r2CzVJg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, Declan Doherty <declan.doherty@intel.com>,
 Chas Williams <chas3@att.com>
To: Chas Williams <3chas3@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 162075F45
 for <dev@dpdk.org>; Wed,  1 Aug 2018 15:48:01 +0200 (CEST)
In-Reply-To: <CAG2-GknPmLqRG_RV+=R3WMYL8hnTff5fo63rk2nPGd4r2CzVJg@mail.gmail.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 8/1/2018 2:34 PM, Chas Williams wrote:
>
>
> On Wed, Aug 1, 2018 at 9:04 AM Radu Nicolau <radu.nicolau@intel.com 
> <mailto:radu.nicolau@intel.com>> wrote:
>
>     Update the bonding promiscuous mode enable/disable functions as to
>     propagate the change to all slaves instead of doing nothing; this
>     seems to be the correct behaviour according to the standard,
>     and also implemented in the linux network stack.
>
>     Signed-off-by: Radu Nicolau <radu.nicolau@intel.com
>     <mailto:radu.nicolau@intel.com>>
>     ---
>      drivers/net/bonding/rte_eth_bond_pmd.c | 8 ++------
>      1 file changed, 2 insertions(+), 6 deletions(-)
>
>     diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
>     b/drivers/net/bonding/rte_eth_bond_pmd.c
>     index ad6e33f..16105cb 100644
>     --- a/drivers/net/bonding/rte_eth_bond_pmd.c
>     +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
>     @@ -2617,12 +2617,10 @@ bond_ethdev_promiscuous_enable(struct
>     rte_eth_dev *eth_dev)
>             case BONDING_MODE_ROUND_ROBIN:
>             case BONDING_MODE_BALANCE:
>             case BONDING_MODE_BROADCAST:
>     +       case BONDING_MODE_8023AD:
>                     for (i = 0; i < internals->slave_count; i++)
>     rte_eth_promiscuous_enable(internals->slaves[i].port_id);
>                     break;
>     -       /* In mode4 promiscus mode is managed when slave is
>     added/removed */
>
>
> This comment is true (and it appears it is always on in 802.3ad mode):
>
>         /* use this port as agregator */
>         port->aggregator_port_id = slave_id;
>         rte_eth_promiscuous_enable(slave_id);
>
> If we are going to do this here, we should probably get rid of it in
> the other location so that future readers aren't confused about which
> is the one doing the work.
>
> Since some adapters don't have group multicast support, we might
> already be in promiscuous anyway.  Turning off promiscuous for
> the bonding master might turn it off in the slaves where an application
> has already enabled it.

The idea was to preserve the current behavior except for the explicit 
promiscuous disable/enable APIs; an application may disable the 
promiscuous mode on the bonding port and then enable it back, expecting 
it to propagate to the slaves.