From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v3 17/21] net/virtio: disable ctrl virtqueue for packed rings Date: Fri, 6 Apr 2018 11:38:50 +0200 Message-ID: <2f621b0a-9c96-d156-31b1-cd5270c8f2bb@redhat.com> References: <20180405101031.26468-1-jfreimann@redhat.com> <20180405101031.26468-18-jfreimann@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: tiwei.bie@intel.com, yliu@fridaylinux.org, mst@redhat.com To: Jens Freimann , dev@dpdk.org Return-path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 4B50B1CED8 for ; Fri, 6 Apr 2018 11:38:53 +0200 (CEST) In-Reply-To: <20180405101031.26468-18-jfreimann@redhat.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 04/05/2018 12:10 PM, Jens Freimann wrote: > Signed-off-by: Jens Freiman > --- > drivers/net/virtio/virtio_ethdev.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index dc220c743..7367d9c5d 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1157,6 +1157,13 @@ virtio_negotiate_features(struct virtio_hw *hw, uint64_t req_features) > req_features &= ~(1ull << VIRTIO_F_RING_PACKED); > #endif > > + if (req_features & (1ULL << VIRTIO_F_RING_PACKED)) { > + req_features &= ~(1ull << VIRTIO_NET_F_CTRL_MAC_ADDR); > + req_features &= ~(1ull << VIRTIO_NET_F_CTRL_VQ); > + req_features &= ~(1ull << VIRTIO_NET_F_CTRL_RX); > + req_features &= ~(1ull << VIRTIO_NET_F_CTRL_VLAN); > + } > + Does packed ring not support ctrl vqs, or is it just a workaround while it is implemented? > /* > * Negotiate features: Subset of device feature bits are written back > * guest feature bits. >