From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v12] net/tap: new TUN/TAP device PMD
Date: Fri, 20 Jan 2017 12:14:43 +0000
Message-ID: <2f632e65-90de-c2b7-ed67-34e3432cefae@intel.com>
References: <1476396234-44694-1-git-send-email-keith.wiles@intel.com>
 <20161212143838.37269-1-keith.wiles@intel.com>
 <dda88bab-a6d6-a842-93be-29f3005227ea@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Cc: pmatilai@redhat.com, yuanhan.liu@linux.intel.com, john.mcnamara@intel.com
To: Keith Wiles <keith.wiles@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 6486BDE5
 for <dev@dpdk.org>; Fri, 20 Jan 2017 13:14:46 +0100 (CET)
In-Reply-To: <dda88bab-a6d6-a842-93be-29f3005227ea@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/13/2016 1:54 PM, Ferruh Yigit wrote:
> On 12/12/2016 2:38 PM, Keith Wiles wrote:
>> The PMD allows for DPDK and the host to communicate using a raw
>> device interface on the host and in the DPDK application. The device
>> created is a Tap device with a L2 packet header.
>>
>> v12- Fixup minor changes for driver_name and version number
>> v11- Add the tap.rst to the nic/index.rst file
>> v10- Change the string name used to allow for multiple devices.
>> v9 - Fix up the docs to use correct syntax
>> v8 - Fix issue with tap_tx_queue_setup() not return zero on success.
>> v7 - Reword the comment in common_base and fix the data->name issue
>> v6 - fixed the checkpatch issues
>> v5 - merge in changes from list review see related emails
>>      fixed many minor edits
>> v4 - merge with latest driver changes
>> v3 - fix includes by removing ifdef for other type besides Linux
>>      Fix the copyright notice in the Makefile
>> v2 - merge all of the patches into one patch
>>      Fix a typo on naming the tap device
>>      Update the maintainers list
>>
>> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
>> ---
> 
>     Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>     Tested-by: Aws Ismail <aismail@ciena.com>
>     Tested-by: Vasily Philipov <vasilyf@mellanox.com>
> 
> Applied to dpdk-next-net/master, thanks.
> 

Hi Keith,

test-report [1] shows build error [2] for the PMD, I guess there is a
kernel version dependency, FYI.

Issue has been caught after integration.


[1]
http://dpdk.org/ml/archives/test-report/2017-January/009616.html


[2]
DPDK/drivers/net/tap/rte_eth_tap.c: In function ‘tun_alloc’:
DPDK/drivers/net/tap/rte_eth_tap.c:143:19: error: ‘IFF_MULTI_QUEUE’
undeclared (first use in this function)
compilation terminated due to -Wfatal-errors.