From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 6/6] examples/ipsec-secgw: config ethernet
 MACs dynamically
Date: Thu, 28 Mar 2019 19:11:26 +0000
Message-ID: <2f6c04b7-0ca6-76fc-14ed-b4998a232250@intel.com>
References: <1507987683-12315-1-git-send-email-aviadye@dev.mellanox.co.il>
 <1508439184-17893-1-git-send-email-aviadye@dev.mellanox.co.il>
 <1508439184-17893-6-git-send-email-aviadye@dev.mellanox.co.il>
 <763A2F19A5EFF34F8B7F1657C992EE297B2F0C70@IRSMSX104.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "Nicolau, Radu" <radu.nicolau@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Akhil Goyal <akhil.goyal@nxp.com>,
 Pablo de Lara <pablo.de.lara.guarch@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>, dpdk-dev <dev@dpdk.org>
To: Aviad Yehezkel <aviadye@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by dpdk.org (Postfix) with ESMTP id 1F814493D
 for <dev@dpdk.org>; Thu, 28 Mar 2019 20:11:35 +0100 (CET)
In-Reply-To: <763A2F19A5EFF34F8B7F1657C992EE297B2F0C70@IRSMSX104.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/20/2017 5:34 PM, radu.nicolau at intel.com (Nicolau, Radu) wrote:
> Hi,
> 
> I think this should be a separate patch, not bundled with a series of fixes.
> The guide has to be updated as well.
> And probably it's best to make the MAC configuration optional, keep a default hardcoded table.

The comment is outstanding since 2017, meanwhile 'ipsec-secgw' changed in between.
I am marking the patch as rejected, if it is still relevant please send a
new version on top of latest repo.

Sorry for any inconvenience caused.

For reference patch:
https://patches.dpdk.org/patch/30613/

> 
> Regards,
> Radu
> 
>> -----Original Message-----
>> From: aviadye at dev.mellanox.co.il [mailto:aviadye at dev.mellanox.co.il]
>> Sent: Thursday, October 19, 2017 7:53 PM
>> To: dev at dpdk.org; Gonzalez Monroy, Sergio
>> <sergio.gonzalez.monroy at intel.com>; De Lara Guarch, Pablo
>> <pablo.de.lara.guarch at intel.com>; aviadye at mellanox.com
>> Cc: borisp at mellanox.com; akhil.goyal at nxp.com;
>> hemant.agrawal at nxp.com; Nicolau, Radu <radu.nicolau at intel.com>;
>> Doherty, Declan <declan.doherty at intel.com>; aviadye at dev.mellanox.co.il;
>> liranl at mellanox.com; nelio.laranjeiro at 6wind.com; thomas at monjalon.net
>> Subject: [dpdk-dev][PATCH v2 6/6] examples/ipsec-secgw: config ethernet
>> MACs dynamically
>>
>> From: Aviad Yehezkel <aviadye at mellanox.com>
>>
>> Issue: None
>> Signed-off-by: Aviad Yehezkel <aviadye at mellanox.com>
>> --
>> v2:
> <snip>
> 
>