From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] lib/lib_eal:add mellanox kernel driver type Date: Mon, 09 Oct 2017 19:27:39 +0200 Message-ID: <3002950.9ou733SsWm@xps> References: <201708230251.v7N2pSSi009414@mse01.zte.com.cn> <20170823080424.GY8124@bidouze.vm.6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org, =?ISO-8859-1?Q?Ga=EBtan?= Rivet , bruce.richardson@intel.com To: Rongqiang XIE Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id C7BF01AFE8 for ; Mon, 9 Oct 2017 19:27:41 +0200 (CEST) In-Reply-To: <20170823080424.GY8124@bidouze.vm.6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/08/2017 10:04, Ga=EBtan Rivet: > Hi, >=20 > On Wed, Aug 23, 2017 at 10:48:01AM +0800, Rongqiang XIE wrote: > > When use bond function in mellanox driver environment, we call the > > find_port_id_by_pci_addr() function,if we don't add mellanox kernel > > driver type in enum rte_kernel_driver, the function will return -1 > > because kdrv unknown, so we add the mellanox driver type, and when > > scan the pci, fill the kdrv to fix this problem. > >=20 >=20 > The issue is not that MLX devices are not properly represented, but > that the find_port_id_by_pci_addr function has a crappy way to recognize > PCI devices. >=20 > The find_device bus operator should be used to find a device having > a specific rte_pci_addr. I described something similar not too long > ago[1]. This matching function would benefit from being properly > rewritten. >=20 > [1]: http://dpdk.org/ml/archives/dev/2017-July/072172.html >=20 > > Signed-off-by: Rongqiang XIE This issue has been fixed as a result of the thread which Gaetan is referencing: http://dpdk.org/browse/dpdk/commit/?id=3Dc848b518bb