From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: rte_eal_init() alternative?
Date: Wed, 02 Sep 2015 15:10:25 +0200
Message-ID: <3003120.8bdQ5bCz5C@xps13>
References: <44e664970fef4bff942eaee5c7eaca67@bilemail1.empirix.com>
 <20150902125650.GA10364@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: "Montorsi, Francesco" <fmontorsi@empirix.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
 [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 3D7F8688E
 for <dev@dpdk.org>; Wed,  2 Sep 2015 15:11:36 +0200 (CEST)
Received: by wicfx3 with SMTP id fx3so18653776wic.0
 for <dev@dpdk.org>; Wed, 02 Sep 2015 06:11:36 -0700 (PDT)
In-Reply-To: <20150902125650.GA10364@bricha3-MOBL3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-09-02 13:56, Bruce Richardson:
> On Wed, Sep 02, 2015 at 12:49:40PM +0000, Montorsi, Francesco wrote:
> > Hi all,
> > 
> > Currently it seems that the only way to initialize EAL is using rte_eal_init() function, correct?
> > 
> > I have the problem that rte_eal_init() will call rte_panic() whenever something fails to initialize or in other cases it will call exit().
> > In my application, I would rather like to attempt DPDK initialization. If it fails I don't want to exit.
> > Unfortunately I cannot even copy&paste the rte_eal_init() code into my application (removing rte_panic and exit calls) since it uses a lot of DPDK internal private functions.
> > 
> > I think that my requirements (avoid abort/exit calls when init fails) is a basic requirement... would you accept a patch that adds an alternative rte_eal_init() function that just returns an error code upon failure, instead of immediately exiting?
> > 
> > Thanks for your hard work!
> > 
> > Francesco Montorsi
> > 
> I, for one, would welcome such a patch. I think the code is overly quick in
> many places to panic or exit the app, when an error code would be more appropriate.
> Feel free to also look at other libraries in DPDK too, if you like :-)

Yes but please, do not create an alternative init function.
We just need to replace panic/exit with error codes and be sure that apps
and examples handle them correctly.
Thanks