From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3] examples/l3fwd: pass flow arguments when
	start app
Date: Tue, 24 Oct 2017 23:44:55 +0200
Message-ID: <3004385.aZoaESbhz5@xps>
References: <1506736748-50515-1-git-send-email-xiaoyun.li@intel.com>
 <1508310691-34865-1-git-send-email-xiaoyun.li@intel.com>
 <9BB6961774997848B5B42BEC655768F810E9FA64@SHSMSX103.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, stephen@networkplumber.com
To: "Wu, Jingjing" <jingjing.wu@intel.com>, "Li,
 Xiaoyun" <xiaoyun.li@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 8A1071B89A
 for <dev@dpdk.org>; Tue, 24 Oct 2017 23:44:57 +0200 (CEST)
In-Reply-To: <9BB6961774997848B5B42BEC655768F810E9FA64@SHSMSX103.ccr.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

24/10/2017 03:38, Wu, Jingjing:
> From: Li, Xiaoyun
> > To make the performance can be tuning on different NICs or platforms. We
> > need to make the number of descriptors as arguments when starting l3fwd
> > application.
> > 
> > Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> 
> Agree to this change.
> 
> Reviewed-by: Jingjing Wu <jingjing.wu@intel.com>

As Stephen, I disagree.

I agree that it may be convenient to test performance tuning.
But it is the purpose of testpmd, not l3fwd example.

This change shows that we need to improve defaults.
I will block this patch in order to get someone working on improvements
in ethdev and drivers.