From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3] pdump: fix vdev cleanup
Date: Tue, 15 Jan 2019 01:59:18 +0100
Message-ID: <3007842.nGy45PVQPd@xps>
References: <20190111174134.39772-1-reshma.pattan@intel.com>
 <20190111175134.40273-1-reshma.pattan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, stable@dpdk.org, ferruh.yigit@intel.com
To: Reshma Pattan <reshma.pattan@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20190111175134.40273-1-reshma.pattan@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

11/01/2019 18:51, Reshma Pattan:
> Virtual devices added in pdump application
> using rte_eal_hotplug_add should be removed explicitly
> while existing the pdump application, otherwise the

existing -> exiting ?

> subsequent run of the pdump application will fail with the reason
> that virtual devices with the same name already exists in primary.
> 
> Fixes: 6362f362a2 ("app/pdump: use EAL hotplug instead of ethdev attach")
> CC: stable@dpdk.org
> CC: ferruh.yigit@intel.com

Why is it marked as a fix of this commit?
Is it a miss in the conversion from ethdev attach calls?
Or a changed behaviour with hotplug functions?