From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 2/4] bnx2x: remove profanity
Date: Tue, 18 Sep 2018 11:40:28 +0200
Message-ID: <3009159.xGyNxZp9MA@xps>
References: <20180725182019.31518-1-stephen@networkplumber.org>
 <20180725182019.31518-3-stephen@networkplumber.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Stephen Hemminger <sthemmin@microsoft.com>,
 Harish Patil <harish.patil@cavium.com>, Rasesh Mody <rasesh.mody@cavium.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 693C94CA2
 for <dev@dpdk.org>; Tue, 18 Sep 2018 11:40:32 +0200 (CEST)
In-Reply-To: <20180725182019.31518-3-stephen@networkplumber.org>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

25/07/2018 20:20, Stephen Hemminger:
> No need for profanity in comments.
> 
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> ---
>  drivers/net/bnx2x/elink.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c
> index 34a29373af3b..08fe817720a1 100644
> --- a/drivers/net/bnx2x/elink.c
> +++ b/drivers/net/bnx2x/elink.c
> @@ -3993,11 +3993,11 @@ static elink_status_t elink_get_mod_abs_int_cfg(struct bnx2x_softc *sc,
>  			   PORT_HW_CFG_E3_MOD_ABS_MASK) >>
>  		    PORT_HW_CFG_E3_MOD_ABS_SHIFT;
>  
> -		/* Should not happen. This function called upon interrupt
> +		/*
> +		 * Should not happen. This function called upon interrupt
>  		 * triggered by GPIO ( since EPIO can only generate interrupts
>  		 * to MCP).
>  		 * So if this function was called and none of the GPIOs was set,
> -		 * it means the shit hit the fan.
>  		 */

It makes the comment ends with a comma, like the end is missing.