From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v8 6/6] build: use dependency for pcap and fallback to find_library Date: Fri, 01 Mar 2019 14:22:10 +0100 Message-ID: <3010022.5H6dhDK0O7@xps> References: <20190103175725.5836-1-bluca@debian.org> <20190226174637.27452-1-luca.boccassi@gmail.com> <20190226174637.27452-6-luca.boccassi@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, bruce.richardson@intel.com To: luca.boccassi@gmail.com Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 49E602B9E for ; Fri, 1 Mar 2019 14:22:15 +0100 (CET) In-Reply-To: <20190226174637.27452-6-luca.boccassi@gmail.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 26/02/2019 18:46, luca.boccassi@gmail.com: > From: Luca Boccassi > > pcap has historically shipped a custom pcap-config binary tool which > does the job of pkg-config. It was never compatible with cross > compilation. > Meson uses it when using dependency(), which then means cross > compilation fails. > Set pcap-config to empty in the meson cross compilation files so > that Meson will not use it, and add a fallback in case > dependency() fails. > libpcap 1.9.0 finally ships a pkg-config file so everything will > work out of the box in the future. > > Signed-off-by: Luca Boccassi > --- > v8: added back pcap change separately. Tested with bootlin > cross-compilation toolchain, everything seems to work. Applied separately of the rest, because I initially thought there was an issue, but it appears to be a transient issue solved by cleaning the build directory. Thanks Luca.