From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 1/2] scripts: add checkpatch wrapper
Date: Thu, 29 Oct 2015 14:03:59 +0100
Message-ID: <3011581.XzQahXhfO1@xps13>
References: <1445615606-3885-1-git-send-email-thomas.monjalon@6wind.com>
 <1445615606-3885-2-git-send-email-thomas.monjalon@6wind.com>
 <CALwxeUvDzX=ZvVQUa+vu6gUKF5GV9qxZ1J6gpqWuAcXrt9m7Vg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: David Marchand <david.marchand@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47])
 by dpdk.org (Postfix) with ESMTP id 5FF768E65
 for <dev@dpdk.org>; Thu, 29 Oct 2015 14:05:10 +0100 (CET)
Received: by wmff134 with SMTP id f134so24013003wmf.1
 for <dev@dpdk.org>; Thu, 29 Oct 2015 06:05:10 -0700 (PDT)
In-Reply-To: <CALwxeUvDzX=ZvVQUa+vu6gUKF5GV9qxZ1J6gpqWuAcXrt9m7Vg@mail.gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-10-29 13:33, David Marchand:
> On Fri, Oct 23, 2015 at 5:53 PM, Thomas Monjalon <thomas.monjalon@6wind.com>
> wrote:
> 
> > +for p in "$@" ; do
> > +       printf -- "\n### $p\n\n"
> > +       report=$($DPDK_CHECKPATCH_PATH $options "$p" 2>/dev/null)
> > +       [ $? -ne 0 ] || continue
> > +       printf '%s\n' "$report" | head -n -6
> > +       status=$(($status + 1))
> > +done
> > +exit $status
> >
> 
> I prefer when checking scripts only complain when something is wrong :-)
> So I would only display the file name if checkpatch complains.

Yes I'll move the first printf after the "continue".