From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] eal/bsdapp: fix device binding at boot Date: Tue, 04 Apr 2017 12:27:05 +0200 Message-ID: <3012960.JsXpb7kNfE@xps13> References: <20170324143011.29279-1-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Bruce Richardson Return-path: Received: from mail-wr0-f170.google.com (mail-wr0-f170.google.com [209.85.128.170]) by dpdk.org (Postfix) with ESMTP id 154B6326B for ; Tue, 4 Apr 2017 12:27:08 +0200 (CEST) Received: by mail-wr0-f170.google.com with SMTP id k6so203465278wre.2 for ; Tue, 04 Apr 2017 03:27:08 -0700 (PDT) In-Reply-To: <20170324143011.29279-1-bruce.richardson@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-03-24 14:30, Bruce Richardson: > When loading nic_uio from /boot/loader.conf as specified in the Getting > Started Guide doc, the NIC devices were not bound at boot. Unloading the > nic_uio driver and reloading it would cause them to be bound, however. > > The root cause appears to be the fact that when the module is loaded at > boot, the call to find the pci device when parsing the b:d:f parameter > fails to return the device. That means that later on when the device > is probed as part of a PCI scan, no action is taken as it's not recorded > as a device to be used. > > We fix this by having the b:d:f string parsed again on probe if the > initial check to see if it's an already-known device fails. In my tests, > this causes the NIC devices to be successfully bound at boot time, as > well as leaving things working as before in the case the module is loaded > post-boot. > > Fixes: 764bf26873b9 ("add FreeBSD support") > > Signed-off-by: Bruce Richardson Cc: stable@dpdk.org Applied, thanks