Re: [PATCH v4 1/4] bus/pci: fix unmap on failure in multi-process

[Thomas Monjalon <thomas@monjalon.net>]

28/01/2026 12:58, Thomas Monjalon:
> This error is seen in build of type "minsize":
> 
> In function 'pci_vfio_map_resource_secondary':
> drivers/bus/pci/linux/pci_vfio.c:1005:28: error:
> 'maps' may be used uninitialized [-Werror=maybe-uninitialized]
>  1005 |                 if (maps[j].addr)
> 
> On failure before assigning maps, it was trying to unmap.
> The fix is changing the goto destination after unmapping.

After David had a look, he told me unmap would never happen
because the loop range is empty.
So we should change this description with this:
"
On failure before assigning maps, it was trying to unmap.
The compiler should have detected that the unmap loop is a nop.

The fix is changing the goto destination after unmapping
to allow compiling with "minsize" option.
"

Because it is not fixing anything but minsize build,
the title should be "bus/pci: fix minsize build"