From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 1/1] hash: separate lf and rw lock lookup code paths Date: Tue, 13 Nov 2018 17:37:44 +0100 Message-ID: <3021164.PQ0aESGyam@xps> References: <20181109163917.16845-1-honnappa.nagarahalli@arm.com> <20181110185534.5444-2-honnappa.nagarahalli@arm.com> <20181111074805.GA3496@jerin> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Jerin Jacob , "bruce.richardson@intel.com" , "pablo.de.lara.guarch@intel.com" , "hemant.agrawal@nxp.com" , "chaozhu@linux.vnet.ibm.com" , "yipeng1.wang@intel.com" , "dharmik.thakkar@arm.com" , "gavin.hu@arm.com" , "nd@arm.com" , "Kapoor, Prasun" To: Honnappa Nagarahalli Return-path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 3BEB434F3 for ; Tue, 13 Nov 2018 17:37:48 +0100 (CET) In-Reply-To: <20181111074805.GA3496@jerin> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 11/11/2018 08:48, Jerin Jacob: > > > > The lock-free algorithm has caused significant lookup > > performance regression for certain use cases. The > > regression is attributed to the use of non-relaxed > > memory orderings. 2 versions of the lookup functions > > are created. One that uses the RW lock and the one that > > is lock-free. This restores the performance regression > > caused for use cases that used RW lock version of the > > lookup function. > > > > Fixes: e605a1d36 ("hash: add lock-free r/w concurrency") > > Cc: honnappa.nagarahalli@arm.com > > > > Suggested-by: Jerin Jacob > > Signed-off-by: Honnappa Nagarahalli > > Reviewed-by: Ola Liljedahl > > Reviewed-by: Gavin Hu > > --- > > Acked-by: Jerin Jacob > Tested-by: Jerin Jacob Applied, thanks