From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] app: fix proc_info app dependency
Date: Fri, 12 Jan 2018 16:41:41 +0100
Message-ID: <3026438.BvA0BSuEar@xps>
References: <ab9cedc7976ffda3060682a55d15d0cb187ad248.1515765793.git.anatoly.burakov@intel.com>
 <1761335.2jqO9XcO2K@xps> <1c158e47-9425-7149-8251-bd2af3bff73f@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, maryam.tahhan@intel.com, stable@dpdk.org
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1c158e47-9425-7149-8251-bd2af3bff73f@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

12/01/2018 16:04, Burakov, Anatoly:
> On 12-Jan-18 2:59 PM, Thomas Monjalon wrote:
> > 12/01/2018 15:17, Anatoly Burakov:
> >> proc_info app is compiled unconditionally on Linux, but it's
> >> actually dependent on librte_ethdev library, which prevents
> >> DPDK from building without librte_ethdev library enabled.
> >>
> >> Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info")
> >> Cc: maryam.tahhan@intel.com
> >> Cc: stable@dpdk.org
> > 
> > nit: please insert a blank line here
> > 
> >> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> >> ---
> >>   DIRS-$(CONFIG_RTE_TEST_PMD) += test-pmd
> >> -DIRS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += proc_info
> >> +ifeq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),y)
> >> +DIRS-$(CONFIG_RTE_LIBRTE_ETHER) += proc_info
> >> +endif
> >>   DIRS-$(CONFIG_RTE_LIBRTE_PDUMP) += pdump
> > 
> > What about pdump and testpmd?
> > 
> > I guess a lot of things do not compile without ethdev, isn't it?
> > 
> 
> True, however one can still disable testpmd compilation with a config 
> option (CONFIG_RTE_TEST_PMD). I guess a better fix for this would be a 
> new config option (i.e. CONFIG_RTE_PROC_INFO)?

Yes, good idea.