From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-stable] [PATCH] examples/quota_watermark: fix
	gcc 8.0.1 cast between incompatible types
Date: Sun, 13 May 2018 23:45:55 +0200
Message-ID: <3027624.dysL5kJjZl@xps>
References: <1525865729-16086-1-git-send-email-reshma.pattan@intel.com>
 <1525865729-16086-2-git-send-email-reshma.pattan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: stable@dpdk.org, dev@dpdk.org
To: Reshma Pattan <reshma.pattan@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1525865729-16086-2-git-send-email-reshma.pattan@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

09/05/2018 13:35, Reshma Pattan:
> Gcc 8.0.1 reports incompatible cast between types i.e. from
> `void (*)(void *)` to `(int (*)(void *)`.
> 
> Change the pipeline_stage prototype to retun int type
> to fix the issue.
> 
> Fixes: a0ffcb257a ("examples/quota_watermark: correct code indentation")
> CC: stable@dpdk.org
> 
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
>  			/* typecast is a workaround for GCC 4.3 bug */
> -			rte_eal_remote_launch((int (*)(void *))pipeline_stage,
> +			rte_eal_remote_launch(pipeline_stage,
>  					NULL, lcore_id);

The comment can be removed.

Applied with above fixed, thanks