From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: Build is broken in dpdk-next-net
Date: Tue, 03 Apr 2018 12:13:11 +0200
Message-ID: <30459437.oZxcDd1rdk@xps>
References: <a28e7585-c312-8b0e-4e6d-1f6621a35feb@solarflare.com>
 <20180402092515.3e5ccea4@xeon-e3>
 <02f1e234-e02c-332c-bf09-77584621cef1@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Stephen Hemminger <stephen@networkplumber.org>,
 Neil Horman <nhorman@tuxdriver.com>,
 =?ISO-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>,
 Tonghao Zhang <xiangxia.m.yue@gmail.com>,
 Timothy Redaelli <tredaelli@redhat.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>, "dev@dpdk.org" <dev@dpdk.org>,
 Ferruh Yigit <ferruh.yigit@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 5FB061B68E
 for <dev@dpdk.org>; Tue,  3 Apr 2018 12:16:53 +0200 (CEST)
In-Reply-To: <02f1e234-e02c-332c-bf09-77584621cef1@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

03/04/2018 10:31, Maxime Coquelin:
> On 04/02/2018 06:25 PM, Stephen Hemminger wrote:
> > Rather than wallpapering over the unused result, why not do real error checking?
> > If the program was run in a non-Linux environment (such as WSL etc), maybe an error
> > could occur. Best to return an error; or at least call rte_exit().
> > 
> 
> Do we really want to call rte_exit() in a library?

No, we must use return.