From mboxrd@z Thu Jan  1 00:00:00 1970
From: dwilder <dwilder@us.ibm.com>
Subject: Re: [PATCH] net/mlx5: fix build on PPC64
Date: Wed, 07 Nov 2018 11:05:24 -0800
Message-ID: <30471765b219a14d31a795ea4d77eedb@linux.vnet.ibm.com>
References: <20180903092911.GU3695@6wind.com>
 <20181107160028.5938-1-thomas@monjalon.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, christian.ehrhardt@canonical.com, adrien.mazarguil@6wind.com,
 shahafs@mellanox.com, yskoh@mellanox.com,
 gowrishankar.m@linux.vnet.ibm.com, chaozhu@linux.vnet.ibm.com,
 pradeep@us.ibm.com, tyos@jp.ibm.com
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com
 [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id 5AF114CA0
 for <dev@dpdk.org>; Wed,  7 Nov 2018 20:02:51 +0100 (CET)
Received: from pps.filterd (m0098404.ppops.net [127.0.0.1])
 by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id
 wA7IwnK6072199 for <dev@dpdk.org>; Wed, 7 Nov 2018 14:02:50 -0500
Received: from e35.co.us.ibm.com (e35.co.us.ibm.com [32.97.110.153])
 by mx0a-001b2d01.pphosted.com with ESMTP id 2nm3dpped6-1
 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT)
 for <dev@dpdk.org>; Wed, 07 Nov 2018 14:02:50 -0500
Received: from localhost
 by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
 Violators will be prosecuted
 for <dev@dpdk.org> from <dwilder@us.ibm.com>;
 Wed, 7 Nov 2018 19:02:49 -0000
In-Reply-To: <20181107160028.5938-1-thomas@monjalon.net>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2018-11-07 08:00, Thomas Monjalon wrote:
> The AltiVec header file breaks boolean type:
> 
> error: incompatible types when initializing type
> '__vector _bool int' {aka '_vector(4) __bool int'} using type 'int'
> 
> If __APPLE_ALTIVEC__ is defined, then bool type is redefined
> and conflicts with stdbool.h.
> 
> There is no good solution to fix it for the whole project without
> breaking something else, so a workaround is inserted in mlx5 PMD.
> This workaround is not compatible with C++ but there is no C++ in DPDK.
> 
> Suggested-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> Suggested-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

<cut ....>

Tested-by: David Wilder <dwilder@us.ibm.com>

Hi Thomas

Thanks for re-posting this patch.  I see no build breaks on power8 or 
power9 with this patch.  I tried both 18.11-rc1 and upstream (master).