From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 2/2] eal: replace strict_strtoul with kstrtoul Date: Fri, 28 Nov 2014 17:45:47 +0100 Message-ID: <3056498.fK5yQdOQol@xps13> References: <1414741039-3531-1-git-send-email-jmiao@redhat.com> <1414741039-3531-3-git-send-email-jmiao@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Jincheng Miao Return-path: In-Reply-To: <1414741039-3531-3-git-send-email-jmiao-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-10-31 15:37, Jincheng Miao: > From upstream kernel commit 3db2e9cd, strict_strto* serial functions > are removed. So that we should directly used kstrtoul instead. > > For compatible with old kernel and RHEL6, add some logic to > igb_uio/compat.h, same as what we do for pci_num_vf(). > > Signed-off-by: Jincheng Miao > --- > lib/librte_eal/linuxapp/igb_uio/compat.h | 8 ++++++++ > lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 4 ++-- > lib/librte_eal/linuxapp/kni/kni_vhost.c | 2 +- > lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c | 2 +- You are replacing strict_strtoul in kni and xen_dom0 without providing a compatibility fallback. -- Thomas