dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] eal: Fix build issue of hotplug with icc
@ 2015-02-27  5:20 Tetsuya Mukawa
       [not found] ` <1425014434-15147-1-git-send-email-mukawa-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Tetsuya Mukawa @ 2015-02-27  5:20 UTC (permalink / raw)
  To: dev-VfR2kkLFssw

This patch fixes following errors with icc.

 error #188: enumerated type mixed with another type
  		return -1;

Reported-by: Mcnamara, John <john.mcnamara-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Tetsuya Mukawa <mukawa-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org>
---
 lib/librte_ether/rte_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index bb94ccb..6ea7a17 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -433,7 +433,7 @@ static enum rte_eth_dev_type
 rte_eth_dev_get_device_type(uint8_t port_id)
 {
 	if (!rte_eth_dev_is_valid_port(port_id))
-		return -1;
+		return RTE_ETH_DEV_UNKNOWN;
 	return rte_eth_devices[port_id].dev_type;
 }
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] eal: Fix build issue of hotplug with icc
       [not found] ` <1425014434-15147-1-git-send-email-mukawa-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org>
@ 2015-02-27 16:58   ` Mcnamara, John
       [not found]     ` <B27915DBBA3421428155699D51E4CFE2EC9BBB-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Mcnamara, John @ 2015-02-27 16:58 UTC (permalink / raw)
  To: Tetsuya Mukawa, dev-VfR2kkLFssw@public.gmane.org

> -----Original Message-----
> From: Tetsuya Mukawa [mailto:mukawa-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org]
> Sent: Friday, February 27, 2015 5:21 AM
> To: dev-VfR2kkLFssw@public.gmane.org
> Cc: Mcnamara, John; Tetsuya Mukawa
> Subject: [PATCH] eal: Fix build issue of hotplug with icc
> 
> This patch fixes following errors with icc.
> 
>  error #188: enumerated type mixed with another type
>   		return -1;


Confirmed that this fixes the issue with ICC 13.1.1.

Acked-by: John McNamara <john.mcnamara-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

-- 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] eal: Fix build issue of hotplug with icc
       [not found]     ` <B27915DBBA3421428155699D51E4CFE2EC9BBB-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
@ 2015-02-27 23:18       ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-02-27 23:18 UTC (permalink / raw)
  To: Tetsuya Mukawa; +Cc: dev-VfR2kkLFssw

> > This patch fixes following errors with icc.
> > 
> >  error #188: enumerated type mixed with another type
> >   		return -1;
> 
> 
> Confirmed that this fixes the issue with ICC 13.1.1.
> 
> Acked-by: John McNamara <john.mcnamara-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-02-27 23:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-27  5:20 [PATCH] eal: Fix build issue of hotplug with icc Tetsuya Mukawa
     [not found] ` <1425014434-15147-1-git-send-email-mukawa-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org>
2015-02-27 16:58   ` Mcnamara, John
     [not found]     ` <B27915DBBA3421428155699D51E4CFE2EC9BBB-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-02-27 23:18       ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).