From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] devargs: fix devargs truncation when format string is used Date: Fri, 20 Jul 2018 11:18:38 +0200 Message-ID: <306416492.6C37yTgp1t@xps> References: <1531898610-19654-1-git-send-email-arybchenko@solarflare.com> <20180718084221.kbryl4ej5rmdioom@bidouze.vm.6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org, =?ISO-8859-1?Q?Ga=EBtan?= Rivet To: Andrew Rybchenko Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id A2589160 for ; Fri, 20 Jul 2018 11:18:44 +0200 (CEST) In-Reply-To: <20180718084221.kbryl4ej5rmdioom@bidouze.vm.6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/07/2018 10:42, Ga=EBtan Rivet: > Hi, >=20 > On Wed, Jul 18, 2018 at 08:23:30AM +0100, Andrew Rybchenko wrote: > > Space for string terminating NUL character should be provided to > > snprintf() to avoid the last symbol truncation. > >=20 > > Fixes: a23bc2c4e01b ("devargs: add non-variadic parsing function") > >=20 > > Reported-by: Ivan Malov > > Signed-off-by: Andrew Rybchenko > Acked-by: Gaetan Rivet Applied, thanks