From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 7/7]app/testpmd: add commands and config functions for i40e flow director support Date: Thu, 28 Aug 2014 14:02:06 +0200 Message-ID: <3064205.9pGcLqH4SI@xps13> References: <1409105634-29980-1-git-send-email-jingjing.wu@intel.com> <32773310.iMGaa2PpNO@xps13> <2601191342CEEE43887BDE71AB9772582135F37F@IRSMSX105.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Ananyev, Konstantin" Return-path: In-Reply-To: <2601191342CEEE43887BDE71AB9772582135F37F-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-08-28 11:30, Ananyev, Konstantin: > From: Thomas Monjalon > > 2014-08-28 09:01, Wu, Jingjing: > > > I have another question: > > > If we use the way 'rx_classification_filter_ctl' works, the specific > > > structures defined in rte_i40e.h will be visible in user's application, > > > such as testpmd. > > > I know I shouldn't make commands linked with i40e like what I did before. > > > But will the i40e specific structures become visible be acceptable? > > > > I think testpmd should be limited to generic API. > > So it wouldn't be acceptable to be dependent of i40e files. > > But having some specific i40e tests in examples or app/test is OK. > > > > Probably I didn't get you right: Indeed ;) > Are you suggesting to have a new clone of testpmd for any new device > we are going to support? No. I say there shouldn't be any PMD dependency on testpmd. It means we should use only generic API. > That seems like too much hassle to me. > Plus what to do if someone would like to test configuration with two > different devices involved: ixgbe and i40e for example? ixgbe and i40e features should use the same generic API for flow director. > I suggest we keep one testpmd for all devices we support. > Of course we'll probably have to make some rework to avoid > if (strncmp(drv_name, "xxx") spread all over it. > We need to find some better way to discover/setup HW specific features. Agreed -- Thomas