From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] qede: fix build issue in the cross-compiling mode Date: Wed, 25 May 2016 19:27:09 +0200 Message-ID: <3064965.ukpxY9gdBn@xps13> References: <1464169261-25455-1-git-send-email-jerin.jacob@caviumnetworks.com> <5745DA7B.2000505@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Jerin Jacob , harish.patil@qlogic.com, Hiroyuki Mikita To: Ferruh Yigit Return-path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 32C542BBC for ; Wed, 25 May 2016 19:27:11 +0200 (CEST) Received: by mail-wm0-f50.google.com with SMTP id n129so71527319wmn.1 for ; Wed, 25 May 2016 10:27:11 -0700 (PDT) In-Reply-To: <5745DA7B.2000505@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-05-25 18:01, Ferruh Yigit: > On 5/25/2016 10:41 AM, Jerin Jacob wrote: > > In cross-compiling mode CC can be aarch64-*-linux-gnu-gcc > > instead of just gcc > > > > Signed-off-by: Jerin Jacob > > --- > > -ifneq (,$(filter gcc gcc48,$(CC))) > > +ifneq (,$(filter %gcc %gcc48,$(CC))) > > What about: ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > This saves adding gcc version or cross compilation related check. True! It could be used instead every occurences of "ifeq ($(CC), icc)" and so on. cc Hiroyuki Mikita It is the same issue with http://dpdk.org/patch/13013