From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v5] vfio: fix workaround of BAR mapping Date: Thu, 26 Jul 2018 11:35:43 +0200 Message-ID: <30652783.zuAJVELDdt@xps> References: <20180712030833.4887-1-t.yoshimura8869@gmail.com> <20180720081347.6123-1-t.yoshimura8869@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Anatoly Burakov To: Takeshi Yoshimura Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 5F5F4326D for ; Thu, 26 Jul 2018 11:35:50 +0200 (CEST) In-Reply-To: <20180720081347.6123-1-t.yoshimura8869@gmail.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/07/2018 10:13, Takeshi Yoshimura: > Currently, VFIO will try to map around MSI-X table in the BARs. When > MSI-X table (page-aligned) size is equal to (page-aligned) size of BAR, > VFIO will just skip the BAR. > > Recent kernel versions will allow VFIO to map the entire BAR containing > MSI-X tables (*), so instead of trying to map around the MSI-X vector > or skipping the BAR entirely if it's not possible, we can now try > mapping the entire BAR first. If mapping the entire BAR doesn't > succeed, fall back to the old behavior of mapping around MSI-X table or > skipping the BAR. > > (*): "vfio-pci: Allow mapping MSIX BAR", > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/ > commit/?id=a32295c612c57990d17fb0f41e7134394b2f35f6 > > Fixes: 90a1633b2347 ("eal/linux: allow to map BARs with MSI-X tables") > > Signed-off-by: Takeshi Yoshimura > Reviewed-by: Anatoly Burakov Applied, thanks