From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] mbuf: clean old refcnt option Date: Fri, 03 Apr 2015 15:57:39 +0200 Message-ID: <3070066.e8G6AS7GDY@xps13> References: <1427824702-5119-1-git-send-email-thomas.monjalon@6wind.com> <2662680.fVrczecCFl@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Ouyang, Changchun" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2015-04-03 05:10, Ouyang, Changchun: > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org] > > 2015-03-31 21:26, Olivier MATZ: > > > On 03/31/2015 07:58 PM, Thomas Monjalon wrote: > > > > CONFIG_RTE_MBUF_SCATTER_GATHER was renamed into > > > > CONFIG_RTE_MBUF_REFCNT by commit 62814bc2e923 and removed by > > commit 4769bc5a27cc. > > > > Some traces remain because of delayed patches. > > > > > > > > It can also be removed from doxygen config. > > > > It is now poisoned in rte_mbuf.h to warn any misuse. > > > > > > > > Fixes: d0dff9ba445e ("doc: sample application user guide") > > > > Fixes: fc1f2750a3ec ("doc: programmers guide") > > > > Fixes: 4769bc5a27cc ("mbuf: remove build option to disable refcnt") > > > > > > > > Signed-off-by: Thomas Monjalon > > > > > I have one doubt about the vhost part, as the previous doc was telling > > > to disable refcnt option and now the behavior is equivalent to having > > > the option always enabled. Also you are removing parts of doc that > > > talk about CONFIG_RTE_LIBRTE_DISTRIBUTOR and > > CONFIG_RTE_LIBRTE_IP_FRAG. > > > > > > It would be safer to also have an acknowledgment from a vhost expert. > > > > Huawei, Changchun, any opinion please? > > Ok to remove it from vhost user doc as the macro in code is removed. > Thanks > Changchun Applied, thanks