From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 6/6] fm10k: use rte_eth_dma_zone_reserve
Date: Wed, 21 Oct 2015 16:37:21 +0200
Message-ID: <3089798.UWYHkBV93j@xps13>
References: <1443487487-31915-1-git-send-email-stephen@networkplumber.org>
 <1443487487-31915-7-git-send-email-stephen@networkplumber.org>
 <CALwxeUtE5KBMvG+-UF15xxmX5McuJqoGjUnDJS=roDwmE3V1aw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com
 [209.85.212.175]) by dpdk.org (Postfix) with ESMTP id 416FE95D9
 for <dev@dpdk.org>; Wed, 21 Oct 2015 16:38:27 +0200 (CEST)
Received: by wicll6 with SMTP id ll6so77715836wic.1
 for <dev@dpdk.org>; Wed, 21 Oct 2015 07:38:27 -0700 (PDT)
In-Reply-To: <CALwxeUtE5KBMvG+-UF15xxmX5McuJqoGjUnDJS=roDwmE3V1aw@mail.gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-10-04 20:44, David Marchand:
> On Tue, Sep 29, 2015 at 2:44 AM, Stephen Hemminger <
> > --- a/drivers/net/fm10k/fm10k_ethdev.c
> > +++ b/drivers/net/fm10k/fm10k_ethdev.c
> > -#ifdef RTE_LIBRTE_XEN_DOM0
> >         q->hw_ring_phys_addr = rte_mem_phy2mch(mz->memseg_id,
> > mz->phys_addr);
> > -#else
> >         q->hw_ring_phys_addr = mz->phys_addr;
> > -#endif
> 
> "else" part has been forgotten.

I could fix it before applying but it would be saner to have a v2.
patchwork status: change requested