From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [PATCH v4 1/2] testpmd: add forwarding mode to
 simulate a noisy neighbour
Date: Wed, 27 Jun 2018 16:09:02 +0200
Message-ID: <308c794e-7aea-c848-5b4c-afeb825c9d21@redhat.com>
References: <20180623080840.315-1-maxime.coquelin@redhat.com>
 <20180623080840.315-2-maxime.coquelin@redhat.com>
 <DB7PR05MB4426256FE2865A0BC4EB361DC3490@DB7PR05MB4426.eurprd05.prod.outlook.com>
 <caf93810-89bb-0a72-9a15-ecd27dc457df@intel.com>
 <DB7PR05MB4426DDCF5DCED8A1C97EE998C3480@DB7PR05MB4426.eurprd05.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "ailan@redhat.com" <ailan@redhat.com>,
 "jan.scheurich@ericsson.com" <jan.scheurich@ericsson.com>,
 "vkaplans@redhat.com" <vkaplans@redhat.com>,
 "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>,
 "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
 Jens Freimann <jfreimann@redhat.com>
To: Shahaf Shuler <shahafs@mellanox.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>,
 "bernard.iremonger@intel.com" <bernard.iremonger@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 by dpdk.org (Postfix) with ESMTP id 81C211BDD8
 for <dev@dpdk.org>; Wed, 27 Jun 2018 16:09:09 +0200 (CEST)
In-Reply-To: <DB7PR05MB4426DDCF5DCED8A1C97EE998C3480@DB7PR05MB4426.eurprd05.prod.outlook.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Sharaf,

On 06/27/2018 03:51 PM, Shahaf Shuler wrote:
> Tuesday, June 26, 2018 4:39 PM, Ferruh Yigit:
>> Subject: Re: [dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to
>> simulate a noisy neighbour
>>
>> On 6/26/2018 1:17 PM, Shahaf Shuler wrote:
>>> HI Maxime, Jens
>>>
>>> Saturday, June 23, 2018 11:09 AM, Maxime Coquelin:
>>>> Subject: [dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to
>>>> simulate a noisy neighbour
>>>>
>>>> From: Jens Freimann <jfreimann@redhat.com>
>>>>
>>>> This adds a new forwarding mode to testpmd to simulate more realistic
>>>> behavior of a guest machine engaged in receiving and sending packets
>>>> performing Virtual Network Function (VNF).
>>>
>>> I really like the idea of adding application w/ more realistic behavior to the
>> DPDK tree in order to use them in the non-regression cycle.
>>>
>>> I am just wondering if putting it as another forward engine in testpmd is
>> the right place for it.
>>
>> Hi Shahaf,
>>
>> This was the request in old review comments. As you said it is good to have
>> more realistic behavior but also we would like to test/use io forwarding, so
>> new forwarding engine is way of having both two.
> 
> Sorry, I missed reading the previous comments.
> As I said, there are upsides and downsides to it. I still think it deserve a separate example but we can start inside testpmd and move it to other location when needed.

I get your point, but I think it is better to have it in testpmd as we
intend to use it to gather some benchmarks.

And yes, if this is turn out to be problematic, we can move it outside
testpmd at some points.

Thanks for your insights,
Maxime