From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] vfio: noiommu check error handling
Date: Mon, 15 Jan 2018 17:11:58 +0100
Message-ID: <30962267.NVMYIIJvp8@xps>
References: <1509465586-7436-1-git-send-email-jpf@zurich.ibm.com>
 <2075027.JcYejM7RvO@xps> <web-42154786@switchplus-mail.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "Burakov, Anatoly" <anatoly.burakov@intel.com>, dev@dpdk.org,
 maxime.coquelin@redhat.com
To: Jonas Pfefferle <pepperjo@japf.ch>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 83CC67CFC
 for <dev@dpdk.org>; Mon, 15 Jan 2018 17:12:30 +0100 (CET)
In-Reply-To: <web-42154786@switchplus-mail.ch>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

15/01/2018 13:22, Jonas Pfefferle:
> 
>   On Sat, 13 Jan 2018 23:49:30 +0100
>   Thomas Monjalon <thomas@monjalon.net> wrote:
> > 13/01/2018 13:15, Burakov, Anatoly:
> >> On 11-Jan-18 11:45 PM, Thomas Monjalon wrote:
> >> > 07/11/2017 10:50, Jonas Pfefferle1:
> >> >>> Is there something urgent for 17.11?
> >> >>> Or can it be refined in 18.02?
> >> >>
> >> >> Nothing urgent. We can refine this for 18.02.
> >> >>
> >> >>> Anatoly, any thought?
> >> > 
> >> > Anatoly, Jonas, how do you want to proceed with this patch?
> >> > 
> >> 
> >> I don't see anything to be refined here, it's a simple bug fix - 
> >>code 
> >> assumes noiommu mode support is always available, when it might not 
> >>be 
> >> the case on older kernels.
> > 
> > As a bug fix, the title must start with "fix" and a tag "Fixes:"
> > must be added to help with backport.
> > At the same time, the explanation of the bug must be added in
> > the commit log please.
> > 
> > Thanks
> 
> It's not really a bug fix since it does not change the semantic of the 
> function but just adds nicer error handling.
> Regarding redefining the code: What I don't like is the special cases 
> we have to check for when using the sPAPR iommu because it does not 
> support VA mappings yet. I think we should decide which iova mode to 
> use based on the iommu types available, i.e. each iommu type should 
> report which iova type it supports. Thoughts?

Have you looked at what Maxime did?
	https://dpdk.org/dev/patchwork/patch/33650/

How does it affect this patch?