From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] testpmd: Fix wrong message when no port started Date: Mon, 23 Mar 2015 14:52:46 +0100 Message-ID: <3096315.kVbCiLpmZB@xps13> References: <1422952659-21557-1-git-send-email-michael.qiu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Michael Qiu , Pablo de Lara Return-path: In-Reply-To: <1422952659-21557-1-git-send-email-michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Pablo, what is your opinion on this patch? 2015-02-03 16:37, Michael Qiu: > The log message is wrong when no port started. > > Signed-off-by: Michael Qiu > --- > app/test-pmd/testpmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 773b8af..ebf9448 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -1423,7 +1423,7 @@ start_port(portid_t pid) > if (need_check_link_status && !no_link_check) > check_all_ports_link_status(nb_ports, RTE_PORT_ALL); > else > - printf("Please stop the ports first\n"); > + printf("Please start at least one port first\n"); Why the word "first"? What could lead to this situation? Wrong pid? Shouldn't be an error returned? > > printf("Done\n"); > return 0;