From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v2 0/4] NFP PF support based on new CPP interface Date: Fri, 6 Apr 2018 15:47:40 +0100 Message-ID: <30ee09ef-57d7-dea1-d034-81f8f0a2a8f4@intel.com> References: <1522939367-5392-1-git-send-email-alejandro.lucero@netronome.com> <802aee06-1bb5-594d-4834-bb7ef7b61813@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Alejandro Lucero , dev@dpdk.org Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 084171D192 for ; Fri, 6 Apr 2018 16:47:44 +0200 (CEST) In-Reply-To: <802aee06-1bb5-594d-4834-bb7ef7b61813@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/6/2018 3:44 PM, Ferruh Yigit wrote: > On 4/5/2018 3:42 PM, Alejandro Lucero wrote: >> NFP PMD PF support requires to access the NFP chip for initialization. >> Current NFP PMD PF support was added based on the NSPU interface. This >> implies to do initialization through the NSP, a embedded ARM processor >> which does initialization tasks on demand. The main problem with this >> approach is it requires to add support for new NSP commands each time >> a new functionality is required, which does not scale well and it is >> not really flexible. >> >> Using the new CPP user space interface, the PMD can do whatever could >> be done by the NSP, this is current commands and any new functionality >> required. This CPP interface allows to access any single chip component >> facilitating initialization, firmware uploading, firmware debugging or >> extended stats. >> >> The changes just change the PMD PF initialization and do not touch the >> datapath at all. No performance changes nor PMD functionalities are affected. >> >> The initial impact using the new CPP interface is the way firmware upload >> is handled, which helps the PMD detecting the card type and the firmware file >> to upload. Future commits will include extended stats and some sort of debug >> channel. >> >> The specific CPP code is contained in the first patch, which has not been >> splitted up because is completely internal to the NFP functionality. The >> second patch makes the PMD changes required for using the new interface. >> >> v2: >> - removing unused reference to zlib.h >> - fix build errors >> - add SPDX tags in new files >> - rebase changes nfp.rst >> >> Alejandro Lucero (4): >> net/nfp: add NFP CPP support >> net/nfp: update PMD for using new CPP interface >> doc: update NFP guide >> net/nfp: remove files > > Series applied to dpdk-next-net/master, thanks. btw, some nfp files seems still missing spdx tags, can you please check them?