From mboxrd@z Thu Jan 1 00:00:00 1970 From: Akhil Goyal Subject: Re: [PATCH v2 15/39] examples/ipsec-secgw: convert to new ethdev offloads API Date: Tue, 9 Jan 2018 12:37:24 +0530 Message-ID: <30ef29c4-0b70-281e-7e8a-0c82b196562a@nxp.com> References: <20171123121419.144132-1-shahafs@mellanox.com> <2cde002e4430cdc6ad44d6d1801994171b7a8340.1513081087.git.shahafs@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit To: "De Lara Guarch, Pablo" , Shahaf Shuler , "dev@dpdk.org" , "Ananyev, Konstantin" , "Nicolau, Radu" , "arybchenko@solarflare.com" Return-path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0075.outbound.protection.outlook.com [104.47.38.75]) by dpdk.org (Postfix) with ESMTP id A8D701B010 for ; Tue, 9 Jan 2018 08:07:31 +0100 (CET) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Pablo, On 1/8/2018 9:57 PM, De Lara Guarch, Pablo wrote: > > >> -----Original Message----- >> From: Shahaf Shuler [mailto:shahafs@mellanox.com] >> Sent: Thursday, December 21, 2017 1:45 PM >> To: De Lara Guarch, Pablo ; >> dev@dpdk.org; Ananyev, Konstantin ; >> Nicolau, Radu ; arybchenko@solarflare.com >> Subject: RE: [dpdk-dev] [PATCH v2 15/39] examples/ipsec-secgw: convert to >> new ethdev offloads API >> >> Hi Pablo and maintainers of ipsec-secgw, >> >> Tuesday, December 19, 2017 2:39 PM, De Lara Guarch, Pablo >>>> diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec- >>>> secgw/ipsec-secgw.c index c98454a..1e8af8d 100644 >>>> --- a/examples/ipsec-secgw/ipsec-secgw.c >>>> +++ b/examples/ipsec-secgw/ipsec-secgw.c >>>> @@ -217,6 +217,9 @@ struct lcore_conf { >>>> }, >>>> .txmode = { >>>> .mq_mode = ETH_MQ_TX_NONE, >>>> + .offloads = (DEV_TX_OFFLOAD_IPV4_CKSUM | >>>> + DEV_TX_OFFLOAD_MULTI_SEGS | >>>> + DEV_TX_OFFLOAD_MBUF_FAST_FREE), >>> >>> Hi Shahaf, >>> >>> Isn't this removing some checksums that were previously done? >>> Txq_flags was set to 0, which means that SCTP, UDP... checksums are >>> disabled now? >> >> You are right that before txqflags were 0, but it doesn't seem the >> application uses any Tx checksum offload beside IPv4, as seen on snipped >> code[1]. >> If I was mistaken and it does uses L4 checksums then I will need to update >> this commit. >> >> Maintainers of this examples - can you confirm? >> > Akhil, Radu, could you confirm that this change is OK for the IPSec app? > There is a v3 already of this patch: http://dpdk.org/dev/patchwork/patch/32711/ > > Thanks, > Pablo > I believe Radu is a better person to review this one. It is related to ethernet offloads. -Akhil