From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v1 1/1] doc: announce ethdev ABI change for
 rte_eth_dev_info.
Date: Thu, 22 Nov 2018 18:27:35 +0000
Message-ID: <30f1a1d5-e38e-c933-e0d0-9800b2470706@intel.com>
References: <1542888549-24656-1-git-send-email-ian.stokes@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: stephen@networkplumber.org, arybchenko@solarflare.com,
 Qi Zhang <qi.z.zhang@intel.com>, Shahaf Shuler <shahafs@mellanox.com>,
 Alejandro Lucero <alejandro.lucero@netronome.com>,
 Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
To: Ian Stokes <ian.stokes@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by dpdk.org (Postfix) with ESMTP id 4C7231B515
 for <dev@dpdk.org>; Thu, 22 Nov 2018 19:27:38 +0100 (CET)
In-Reply-To: <1542888549-24656-1-git-send-email-ian.stokes@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 11/22/2018 12:09 PM, Ian Stokes wrote:
> Maximum and minimum MTU values vary between hardware devices. In
> hardware agnostic DPDK applications access to such information would
> allow a more accurate way of validating and setting supported MTU values on
> a per device basis rather than using a defined default for all devices.
> 
> The following solution was proposed:
> 
> http://mails.dpdk.org/archives/dev/2018-September/110959.html
> 
> This patch adds a depreciation notice for ``rte_eth_dev_info`` as new
> members will be added to represent min and max MTU values. These can be
> added to fit a hole in the existing structure for amd64 but not for 32 bit,
> as such ABI change will occur as size of the structure will be impacted.
> 
> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 34b28234c..da2b1ce15 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -49,6 +49,18 @@ Deprecation Notices
>    Target release for removal of the legacy API will be defined once most
>    PMDs have switched to rte_flow.
>  
> +* ethdev: Maximum and minimum MTU values vary between hardware devices. In
> +  hardware agnostic DPDK applications access to such information would allow
> +  a more accurate way of validating and setting supported MTU values on a per
> +  device basis rather than using a defined default for all devices. To
> +  resolve this, the following members will be added to ``rte_eth_dev_info``.
> +  Note: these can be added to fit a hole in the existing structure for amd64
> +  but not for 32 bit, as such ABI change will occur as size of the structure
> +  will increase.
> +
> +  - Member ``uint16_t min_mtu`` the minimum MTU allowed.
> +  - Member ``uint16_t max_mtu`` the maximum MTU allowed.
> +
>  * pdump: As we changed to use generic IPC, some changes in APIs and structure
>    are expected in subsequent release.
>  
> 

cc'ed a few more folks.