From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] net/e1000: fix memcpy length error
Date: Tue, 19 Sep 2017 10:16:16 +0100
Message-ID: <30f82422-1147-1b8b-4f09-d0565960044f@intel.com>
References: <1505220240-30600-1-git-send-email-wang.yong19@zte.com.cn>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Yong Wang <wang.yong19@zte.com.cn>, wenzhuo.lu@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 98640DE0
 for <dev@dpdk.org>; Tue, 19 Sep 2017 11:16:19 +0200 (CEST)
In-Reply-To: <1505220240-30600-1-git-send-email-wang.yong19@zte.com.cn>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/12/2017 1:44 PM, Yong Wang wrote:
> The size of "flex_filter.filter_info.mask" and "filter->mask" is 16
> bytes, but the length of memcpy--"RTE_ALIGN(filter->len, sizeof(char))
> / sizeof(char)" may reach 128 bytes which may cause array access out
> of bound. Fix it by replacing "sizeof(char)" by "CHAR_BIT".
> 
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>