From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 1/1] ethdev: distinguish between drop and error stats Date: Tue, 03 Nov 2015 00:46:57 +0100 Message-ID: <3108772.cu7MlmvWl0@xps13> References: <1445257253-3673-1-git-send-email-maryam.tahhan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Maryam Tahhan Return-path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 651768E6C for ; Tue, 3 Nov 2015 00:48:08 +0100 (CET) Received: by wmec75 with SMTP id c75so73625441wme.1 for ; Mon, 02 Nov 2015 15:48:08 -0800 (PST) In-Reply-To: <1445257253-3673-1-git-send-email-maryam.tahhan@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-10-19 13:20, Maryam Tahhan: > Make a distniction between dropped packets and error statistics to allow > a higher level fault management entity to interact with DPDK and take > appropriate measures when errors are detected. It will also provide > valuable information for any applications that collects/extracts DPDK > stats, such applications include Open vSwitch. > After this patch the distinction is: > ierrors = Total number of packets dropped by hardware (malformed > packets, ...) Where the # of drops can ONLY be <= the packets received > (without overlap between registers). > ipkterrors = Total number of erroneous received packets. Where the # > of errors can be >= the packets received (without overlap between > registers), this is because there may be multiple errors associated with > a packet. [...] > - uint64_t ierrors; /**< Total number of erroneous received packets. */ > + uint64_t ierrors; > + /**< Total number of packets dropped by hardware (malformed packets...) > + * Where the # of drops can ONLY be <= the packets received (without > + * overlap between registers). > + */ > uint64_t oerrors; /**< Total number of failed transmitted packets. */ > + uint64_t ipkterrors; > + /**< Total number of erroneous received packets. Where the number of > + * errors can be >= the packets received (without overlap between > + * registers), this is because there may be multiple errors associated with > + * a packet. > + */ There was not a lot of comments on this proposal. If the idea is well received, it needs to be implemented in drivers, at least few of them.