From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3] mk: stop on warning only in developer
	build
Date: Thu, 03 Mar 2016 11:36:28 +0100
Message-ID: <3110515.Sqe0BZWodk@xps13>
References: <9190554.3JBlDK3N1R@xps13>
 <1456928543-23329-1-git-send-email-thomas.monjalon@6wind.com>
 <20160302220453.GE8804@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: pmatilai@redhat.com
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id 9527D2906
 for <dev@dpdk.org>; Thu,  3 Mar 2016 11:38:04 +0100 (CET)
Received: by mail-wm0-f44.google.com with SMTP id l68so25695428wml.1
 for <dev@dpdk.org>; Thu, 03 Mar 2016 02:38:04 -0800 (PST)
In-Reply-To: <20160302220453.GE8804@bricha3-MOBL3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-03-02 22:04, Bruce Richardson:
> On Wed, Mar 02, 2016 at 03:22:23PM +0100, Thomas Monjalon wrote:
> > From: Panu Matilainen <pmatilai@redhat.com>
> > 
> > Add RTE_DEVEL_BUILD make-variable which can be used to do things
> > differently when doing development vs building a release,
> > autodetected from source root .git presence and overridable via
> > commandline. It is used it to enable -Werror compiler flag and may
> > be extended to other checks.
> > 
> > Failing build on warnings is a useful developer tool but its bad
> > for release tarballs which can and do get built with newer
> > compilers than what was used/available during development. Compilers
> > routinely add new warnings so code which built silently with cc X
> > might no longer do so with X+1. This doesn't make the existing code
> > any more buggier and failing the build in this case does not help
> > to improve the quality of an already released version either.
> > 
> > This change the default flags which can be tuned with EXTRA_CFLAGS.
> > 
> > Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks

If people have problems compiling previous releases,
please remind to use EXTRA_CFLAGS=-Wno-error